procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix minor problem in stack probing

Browse source 
probe_stack_range has an assert to capture the possibility that that
expand_binop might not construct its result in the provided target.

We triggered that internally a little while ago.  I'm pretty sure it was in the
testsuite, so no new testcase.  The fix is easy, copy the result into the
proper target when needed.

Bootstrapped and regression tested on x86.

gcc/
	* explow.cc (probe_stack_range): Handle case when expand_binop
	does not construct its result in the expected location.
This commit is contained in:
Jeff Law 2023-10-16 17:14:38 -06:00
parent 04013e4464
commit b626751a4e
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gcc/explow.cc
View file

@ -1818,7 +1818,10 @@ probe_stack_range (HOST_WIDE_INT first, rtx size)
gen_int_mode (PROBE_INTERVAL, Pmode), test_addr,
1, OPTAB_WIDEN);
gcc_assert (temp == test_addr);
/* There is no guarantee that expand_binop constructs its result
in TEST_ADDR. So copy into TEST_ADDR if necessary. */
if (temp != test_addr)
emit_move_insn (test_addr, temp);
/* Probe at TEST_ADDR. */
emit_stack_probe (test_addr);