From aee857a2f4fbbcf0d3fde1d80c8c40d53b5edab1 Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Tue, 7 Oct 2008 18:45:56 +0000 Subject: [PATCH] re PR middle-end/37731 (long long may not work correctly on 32bit host) gcc/ 2008-10-07 H.J. Lu PR middle-end/37731 * expmed.c (expand_mult): Properly check DImode constant in CONST_DOUBLE. gcc/testsuite/ 2008-10-07 H.J. Lu PR middle-end/37731 * gcc.dg/torture/pr37731-1.c: New. * gcc.dg/torture/pr37731-2.c: Likewise. From-SVN: r140947 --- gcc/ChangeLog | 6 ++++++ gcc/expmed.c | 3 ++- gcc/testsuite/ChangeLog | 6 ++++++ gcc/testsuite/gcc.dg/torture/pr37731-1.c | 17 +++++++++++++++++ gcc/testsuite/gcc.dg/torture/pr37731-2.c | 17 +++++++++++++++++ 5 files changed, 48 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.dg/torture/pr37731-1.c create mode 100644 gcc/testsuite/gcc.dg/torture/pr37731-2.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 5582866162a..18911a224f4 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2008-10-07 H.J. Lu + + PR middle-end/37731 + * expmed.c (expand_mult): Properly check DImode constant in + CONST_DOUBLE. + 2008-10-07 Jakub Jelinek PR debug/37738 diff --git a/gcc/expmed.c b/gcc/expmed.c index ae5ad0a2f12..5e8d7f30324 100644 --- a/gcc/expmed.c +++ b/gcc/expmed.c @@ -3075,7 +3075,8 @@ expand_mult (enum machine_mode mode, rtx op0, rtx op1, rtx target, { /* If we are multiplying in DImode, it may still be a win to try to work with shifts and adds. */ - if (CONST_DOUBLE_HIGH (op1) == 0) + if (CONST_DOUBLE_HIGH (op1) == 0 + && CONST_DOUBLE_LOW (op1) > 0) coeff = CONST_DOUBLE_LOW (op1); else if (CONST_DOUBLE_LOW (op1) == 0 && EXACT_POWER_OF_2_OR_ZERO_P (CONST_DOUBLE_HIGH (op1))) diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index d3fdf004267..b33a77a0658 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2008-10-07 H.J. Lu + + PR middle-end/37731 + * gcc.dg/torture/pr37731-1.c: New. + * gcc.dg/torture/pr37731-2.c: Likewise. + 2008-10-07 Jakub Jelinek PR debug/37738 diff --git a/gcc/testsuite/gcc.dg/torture/pr37731-1.c b/gcc/testsuite/gcc.dg/torture/pr37731-1.c new file mode 100644 index 00000000000..5c156b1f9a6 --- /dev/null +++ b/gcc/testsuite/gcc.dg/torture/pr37731-1.c @@ -0,0 +1,17 @@ +/* { dg-do run } */ + +extern void abort (); + +unsigned long long xh = 1; + +int +main () +{ + unsigned long long yh = 0xffffffffull; + unsigned long long z = xh * yh; + + if (z != yh) + abort (); + + return 0; +} diff --git a/gcc/testsuite/gcc.dg/torture/pr37731-2.c b/gcc/testsuite/gcc.dg/torture/pr37731-2.c new file mode 100644 index 00000000000..a7f8f1e02e5 --- /dev/null +++ b/gcc/testsuite/gcc.dg/torture/pr37731-2.c @@ -0,0 +1,17 @@ +/* { dg-do run } */ + +extern void abort (); + +long long xh = 1; + +int +main () +{ + long long yh = 0xffffffffll; + long long z = xh * yh; + + if (z != yh) + abort (); + + return 0; +}