procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

re PR fortran/35152 (Implicit procedure with keyword=argument is accepted)

Browse source 
gcc/fortran:
2008-03-19  Daniel Franke  <franke.daniel@gmail.com>

        PR fortran/35152
        * interface.c (gfc_procedure_use): Check for keyworded arguments in
        procedures without explicit interfaces.

gcc/testsuite:
2008-03-19  Daniel Franke  <franke.daniel@gmail.com>

        PR fortran/35152
        * gfortran.dg/argument_checking_16.f90: New test.

From-SVN: r133347
This commit is contained in:
Daniel Franke 2008-03-19 15:13:48 -04:00 • committed by Daniel Franke
parent 2f3b8279bf
commit ac05557cc7
4 changed files with 40 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gcc/fortran/ChangeLog
View file

@ -1,3 +1,9 @@
2008-03-19 Daniel Franke <franke.daniel@gmail.com>
PR fortran/35152
* interface.c (gfc_procedure_use): Check for keyworded arguments in
procedures without explicit interfaces.
2008-03-16 Paul Thomas <pault@gcc.gnu.org>
PR fortran/35470

23
gcc/fortran/interface.c
View file

@ -2419,9 +2419,26 @@ gfc_procedure_use (gfc_symbol *sym, gfc_actual_arglist **ap, locus *where)
}
}
if (sym->attr.if_source == IFSRC_UNKNOWN
|| !compare_actual_formal (ap, sym->formal, 0,
sym->attr.elemental, where))
if (sym->attr.external
|| sym->attr.if_source == IFSRC_UNKNOWN)
{
gfc_actual_arglist *a;
for (a = *ap; a; a = a->next)
{
/* Skip g77 keyword extensions like %VAL, %REF, %LOC. */
if (a->name != NULL && a->name[0] != '%')
{
gfc_error("Keyword argument requires explicit interface "
"for procedure '%s' at %L", sym->name, &a->expr->where);
break;
}
}
return;
}
if (!compare_actual_formal (ap, sym->formal, 0,
sym->attr.elemental, where))
return;
check_intents (sym->formal, *ap);

5
gcc/testsuite/ChangeLog
View file

@ -1,3 +1,8 @@
2008-03-19 Daniel Franke <franke.daniel@gmail.com>
PR fortran/35152
* gfortran.dg/argument_checking_16.f90: New test.
2008-03-19 Thomas Koenig <tkoenig@gcc.gnu.org>
PR libfortran/32972

9
gcc/testsuite/gfortran.dg/argument_checking_16.f90 Normal file
View file

@ -0,0 +1,9 @@
! { dg-do compile }
! PR fortran/35152 - implicit procedure with keyword=argument
external bar
call bar(a=5) ! { dg-error "requires explicit interface" }
call foo(a=5) ! { dg-error "requires explicit interface" }
end