procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

c++: Distinguish ambiguity from no valid candidate

Browse source 
Several recent C++ features are specified to try overload resolution, and if
no viable candidate is found, do something else.  But our error return
doesn't distinguish between that situation and finding multiple viable
candidates that end up being ambiguous.  We're already trying to separately
return the single function we found even if it ends up being ill-formed for
some reason; for ambiguity let's pass back error_mark_node, to be
distinguished from NULL_TREE meaning no viable candidate.

gcc/cp/ChangeLog:

	* call.c (build_new_op_1): Set *overload for ambiguity.
	(build_new_method_call_1): Likewise.
This commit is contained in:
Jason Merrill 2020-12-07 17:21:47 -05:00
parent 447f99b3b8
commit a988a398d6
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
gcc/cp/call.c
View file

@ -6357,6 +6357,8 @@ build_new_op_1 (const op_location_t &loc, enum tree_code code, int flags,
print_z_candidates (loc, candidates);
}
result = error_mark_node;
if (overload)
*overload = error_mark_node;
}
else if (TREE_CODE (cand->fn) == FUNCTION_DECL)
{
@ -10438,6 +10440,8 @@ build_new_method_call_1 (tree instance, tree fns, vec<tree, va_gc> **args,
free (pretty_name);
}
call = error_mark_node;
if (fn_p)
*fn_p = error_mark_node;
}
else
{