procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

re PR libfortran/80727 (Crash of runtime gfortran library during integer transformation)

Browse source 
2017-05-15  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

	PR libgfortran/80727
	* transfer.c (read_sf_internal): Remove bogus code to detect EOR.
	(read_block_form): For internal units, generate EOR if no more
	bytes left in unit and we are trying to read with ADVANCE='NO'.

	* gfortran.dg/read_3.f90: New test.

From-SVN: r248080
This commit is contained in:
Jerry DeLisle 2017-05-15 23:48:39 +00:00
parent b2954e124b
commit a5768d38a6
4 changed files with 42 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gcc/testsuite/ChangeLog
View file

@ -1,3 +1,8 @@
2017-05-15 Jerry DeLisle <jvdelisle@gcc.gnu.org>
PR libgfortran/80727
* gfortran.dg/read_3.f90: New test.
2017-05-15 Nathan Sidwell <nathan@acm.org>
PR c++/79369

13
gcc/testsuite/gfortran.dg/read_3.f90 Normal file
View file

@ -0,0 +1,13 @@
! { dg-do run }
! PR80727 Crash of runtime gfortran library during integer transformation
! Note: before the patch this was giving an incorrect EOR error on READ.
program gfortran_710_io_bug
character str*4
integer(4) :: i4
str =''
i = 256
write(str,fmt='(a)') i
i = 0
read ( unit=str(1:4), fmt='(a)' ) i4
if (i4.ne.256) call abort
end program gfortran_710_io_bug

7
libgfortran/ChangeLog
View file

@ -1,3 +1,10 @@
2017-05-15 Jerry DeLisle <jvdelisle@gcc.gnu.org>
PR libgfortran/80727
* transfer.c (read_sf_internal): Remove bogus code to detect EOR.
(read_block_form): For internal units, generate EOR if no more
bytes left in unit and we are trying to read with ADVANCE='NO'.
2017-05-15 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/80765

27
libgfortran/io/transfer.c
View file

@ -272,12 +272,6 @@ read_sf_internal (st_parameter_dt *dtp, int *length)
return NULL;
}
if (base && *base == 0)
{
generate_error (&dtp->common, LIBERROR_EOR, NULL);
return NULL;
}
dtp->u.p.current_unit->bytes_left -= *length;
if (((dtp->common.flags & IOPARM_DT_HAS_SIZE) != 0) ||
@ -470,11 +464,24 @@ read_block_form (st_parameter_dt *dtp, int *nbytes)
}
}
if (unlikely (dtp->u.p.current_unit->bytes_left == 0
&& !is_internal_unit(dtp)))
if (is_internal_unit(dtp))
{
hit_eof (dtp);
return NULL;
if (*nbytes > 0 && dtp->u.p.current_unit->bytes_left == 0)
{
if (dtp->u.p.advance_status == ADVANCE_NO)
{
generate_error (&dtp->common, LIBERROR_EOR, NULL);
return NULL;
}
}
}
else
{
if (unlikely (dtp->u.p.current_unit->bytes_left == 0))
{
hit_eof (dtp);
return NULL;
}
}
*nbytes = dtp->u.p.current_unit->bytes_left;