procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

i386: Correct target attribute for crc32 intrinsics

Browse source 
Complile _mm_crc32_u8/16/32/64 intrinsics with -mcrc32
would meet target specific option mismatch. Correct target pragma
to fix.

gcc/ChangeLog:

	* config/i386/smmintrin.h: Correct target pragma from sse4.1
	and sse4.2 to crc32 for crc32 intrinsics.

gcc/testsuite/ChangeLog:

	* gcc.target/i386/crc32-6.c: Adjust dg-error message.
	* gcc.target/i386/crc32-7.c: New test.
This commit is contained in:
Hongyu Wang 2022-04-15 10:51:06 +08:00
parent e580f81d22
commit a335a94a1b
3 changed files with 42 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
gcc/config/i386/smmintrin.h
View file

@ -810,17 +810,11 @@ _mm_cmpgt_epi64 (__m128i __X, __m128i __Y)
#include <popcntintrin.h>
#ifndef __SSE4_1__
#ifndef __CRC32__
#pragma GCC push_options
#pragma GCC target("sse4.1")
#define __DISABLE_SSE4_1__
#endif /* __SSE4_1__ */
#ifndef __SSE4_2__
#pragma GCC push_options
#pragma GCC target("sse4.2")
#define __DISABLE_SSE4_2__
#endif /* __SSE4_1__ */
#pragma GCC target("crc32")
#define __DISABLE_CRC32__
#endif /* __CRC32__ */
/* Accumulate CRC32 (polynomial 0x11EDC6F41) value. */
extern __inline unsigned int __attribute__((__gnu_inline__, __always_inline__, __artificial__))
@ -849,14 +843,9 @@ _mm_crc32_u64 (unsigned long long __C, unsigned long long __V)
}
#endif
#ifdef __DISABLE_SSE4_2__
#undef __DISABLE_SSE4_2__
#ifdef __DISABLE_CRC32__
#undef __DISABLE_CRC32__
#pragma GCC pop_options
#endif /* __DISABLE_SSE4_2__ */
#ifdef __DISABLE_SSE4_1__
#undef __DISABLE_SSE4_1__
#pragma GCC pop_options
#endif /* __DISABLE_SSE4_1__ */
#endif /* __DISABLE_CRC32__ */
#endif /* _SMMINTRIN_H_INCLUDED */

2
gcc/testsuite/gcc.target/i386/crc32-6.c
View file

@ -10,4 +10,4 @@ test_mm_crc32_u8 (unsigned int CRC, unsigned char V)
return _mm_crc32_u8 (CRC, V);
}
/* { dg-error "needs isa option -mcrc32" "" { target *-*-* } 0 } */
/* { dg-error "target specific option mismatch" "" { target *-*-* } 0 } */

34
gcc/testsuite/gcc.target/i386/crc32-7.c Normal file
View file

@ -0,0 +1,34 @@
/* { dg-do compile } */
/* { dg-options "-O2 -mcrc32" } */
/* { dg-final { scan-assembler "crc32b\[^\\n\]*eax" } } */
/* { dg-final { scan-assembler "crc32w\[^\\n\]*eax" } } */
/* { dg-final { scan-assembler "crc32l\[^\\n\]*eax" } } */
/* { dg-final { scan-assembler "crc32q\[^\\n\]*rax" { target { ! ia32 } } } } */
#include <immintrin.h>
unsigned int
test_mm_crc32_u8 (unsigned int CRC, unsigned char V)
{
return _mm_crc32_u8 (CRC, V);
}
unsigned int
test_mm_crc32_u16 (unsigned int CRC, unsigned short V)
{
return _mm_crc32_u16 (CRC, V);
}
unsigned int
test_mm_crc32_u32 (unsigned int CRC, unsigned int V)
{
return _mm_crc32_u32 (CRC, V);
}
#ifdef __x86_64__
unsigned long long
test_mm_crc32_u64 (unsigned long long CRC, unsigned long long V)
{
return _mm_crc32_u64 (CRC, V);
}
#endif