procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

arc.c (arc_loop_hazard): Don't convert the jump label rtx to an rtx_insn until we confirm it's not a...

Browse source 
2015-12-17  Andrew Burgess  <andrew.burgess@embecosm.com>
gcc:
        * config/arc/arc.c (arc_loop_hazard): Don't convert the jump label
        rtx to an rtx_insn until we confirm it's not a return rtx.
gcc/testsuite:
        * gcc.target/arc/loop-hazard-1.c: New file

From-SVN: r231752
This commit is contained in:
Andrew Burgess 2015-12-17 10:53:43 +00:00 • committed by Joern Rennecke
parent 38fc3edcb9
commit a30c5ca4c1
4 changed files with 33 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gcc/ChangeLog
View file

@ -1,3 +1,8 @@
2015-12-17 Andrew Burgess <andrew.burgess@embecosm.com>
* config/arc/arc.c (arc_loop_hazard): Don't convert the jump label
rtx to an rtx_insn until we confirm it's not a return rtx.
2015-12-17 Richard Biener <rguenther@suse.de>
* gimple-ssa.h (struct gimple_df): Remove modified_noreturn_calls

15
gcc/config/arc/arc.c
View file

@ -8041,6 +8041,7 @@ static bool
arc_loop_hazard (rtx_insn *pred, rtx_insn *succ)
{
rtx_insn *jump = NULL;
rtx label_rtx = NULL_RTX;
rtx_insn *label = NULL;
basic_block succ_bb;
@ -8067,22 +8068,22 @@ arc_loop_hazard (rtx_insn *pred, rtx_insn *succ)
else
return false;
label = JUMP_LABEL_AS_INSN (jump);
if (!label)
return false;
/* Phase 2b: Make sure is not a millicode jump. */
if ((GET_CODE (PATTERN (jump)) == PARALLEL)
&& (XVECEXP (PATTERN (jump), 0, 0) == ret_rtx))
return false;
/* Phase 2c: Make sure is not a simple_return. */
if ((GET_CODE (PATTERN (jump)) == SIMPLE_RETURN)
|| (GET_CODE (label) == SIMPLE_RETURN))
label_rtx = JUMP_LABEL (jump);
if (!label_rtx)
return false;
/* Phase 2c: Make sure is not a return. */
if (ANY_RETURN_P (label_rtx))
return false;
/* Pahse 2d: Go to the target of the jump and check for aliveness of
LP_COUNT register. */
label = safe_as_a <rtx_insn *> (label_rtx);
succ_bb = BLOCK_FOR_INSN (label);
if (!succ_bb)
{

4
gcc/testsuite/ChangeLog
View file

@ -10,6 +10,10 @@
* gcc.dg/darwin-20040809-2.c: Likewise.
* objc.dg/stabs-1.m: Likewise.
2015-12-17 Andrew Burgess <andrew.burgess@embecosm.com>
* gcc.target/arc/loop-hazard-1.c: New file.
2015-12-17 Andrew Burgess <andrew.burgess@embecosm.com>
* gcc.target/arc/jump-around-jump.c (rtc_set_time): Declare.

16
gcc/testsuite/gcc.target/arc/loop-hazard-1.c Normal file
View file

@ -0,0 +1,16 @@
/* { dg-do compile } */
/* { dg-options "-Os" } */
/* This caused an assertion within arc_loop_hazard. */
unsigned a, b;
long fn1()
{
long c = 1, d = 0;
while (a && c && b)
c <<= 1;
while (c)
d |= c;
return d;
}