target: [PR102941] Fix inline-asm flags with non-REG_P output

So the problem here is that arm_md_asm_adjust would
just create a set directly to the output memory which is wrong.
It needs to output to a temp register first and then do a
move.

OK? Bootstrapped and tested on aarch64-linux-gnu with no regressions.
I have no way to test on arm even though this touches common code.

	PR target/102941

gcc/ChangeLog:

	* config/arm/aarch-common.c (arm_md_asm_adjust):
	Use a temp if !REG_P.

gcc/testsuite/ChangeLog:

	* gcc.target/aarch64/asm-flag-7.c: New test.
	* gcc.target/arm/asm-flag-7.c: New test.
This commit is contained in:
Andrew Pinski 2021-10-26 07:28:09 +00:00
parent 42ae7ebfb2
commit 997130f778
3 changed files with 46 additions and 1 deletions

View file

@ -641,7 +641,7 @@ arm_md_asm_adjust (vec<rtx> &outputs, vec<rtx> & /*inputs*/,
rtx x = gen_rtx_REG (mode, CC_REGNUM);
x = gen_rtx_fmt_ee (code, word_mode, x, const0_rtx);
if (dest_mode == word_mode)
if (dest_mode == word_mode && REG_P (dest))
emit_insn (gen_rtx_SET (dest, x));
else
{

View file

@ -0,0 +1,22 @@
/* Test that "=@cc*" works with MEM_P RTX */
/* PR target/102941 */
/* { dg-do compile } */
/* { dg-options "-O" } */
#ifndef __GCC_ASM_FLAG_OUTPUTS__
#error "missing preprocessor define"
#endif
int test_cmpu_x;
void f(long *);
long
test_cmpu_y() {
long le;
f(&le);
__asm__("cmp %"
"[x], %"
"[y]"
: "=@ccls"(le)
: [x] ""(test_cmpu_x), [y] ""(test_cmpu_y));
return le;
}

View file

@ -0,0 +1,23 @@
/* Test that "=@cc*" works with MEM_P RTX */
/* PR target/102941 */
/* { dg-do compile } */
/* { dg-options "-O" } */
/* { dg-skip-if "" { arm_thumb1 } } */
#ifndef __GCC_ASM_FLAG_OUTPUTS__
#error "missing preprocessor define"
#endif
int test_cmpu_x;
void f(long *);
long
test_cmpu_y() {
long le;
f(&le);
__asm__("cmp %"
"[x], %"
"[y]"
: "=@ccls"(le)
: [x] ""(test_cmpu_x), [y] ""(test_cmpu_y));
return le;
}