procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ada: Fix up handling of ghost units [PR104027]

Browse source 
As reported, libgnat-12.so gets PT_GNU_STACK RWE, which means it doesn't
work in some SELinux configurations.
This is caused by the a-nbnbig.o file, which is a ghost unit and since
r12-5670 the FE emits an object file for it, but exits before compile_file
has a chance to finalize it e.g. with targetm.asm_out.file_end ()
that emits the .note.GNU-stack section on various linux targets.

Fixed by not existing but instead returning early to the caller.

2022-01-14  Andrew Pinski  <apinski@marvell.com>

	PR ada/104027
	* gnat1drv.adb (Gnat1drv): After Back_End.Gen_Or_Update_Object_File
	goto End_Of_Program.
This commit is contained in:
Andrew Pinski 2022-01-14 23:58:38 +01:00 • committed by Jakub Jelinek
parent cc3b67e401
commit 952b7dbb41
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gcc/ada/gnat1drv.adb
View file

@ -1429,6 +1429,11 @@ begin
Ecode := E_Success;
Back_End.Gen_Or_Update_Object_File;
-- Use a goto instead of calling Exit_Program so that finalization
-- occurs normally.
goto End_Of_Program;
-- Otherwise the unit is missing a crucial piece that prevents code
-- generation.