procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

re PR c/66341 (Some casts wrongly produce a lvalue)

Browse source 
PR c/66341
	* c-typeck.c (build_c_cast): Wrap VALUE into NON_LVALUE_EXPR if
	it is a lvalue.

	* gcc.dg/lvalue-8.c: New test.

From-SVN: r224115
This commit is contained in:
Marek Polacek 2015-06-04 08:17:45 +00:00 • committed by Marek Polacek
parent 0b98bb4e15
commit 9482b620d2
4 changed files with 31 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gcc/c/ChangeLog
View file

@ -1,3 +1,9 @@
2015-06-04 Marek Polacek <polacek@redhat.com>
PR c/66341
* c-typeck.c (build_c_cast): Wrap VALUE into NON_LVALUE_EXPR if
it is a lvalue.
2015-06-03 Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>
* c-decl.c (warn_cxx_compat_finish_struct): New parameters code, record_loc.

2
gcc/c/c-typeck.c
View file

@ -5195,7 +5195,7 @@ build_c_cast (location_t loc, tree type, tree expr)
}
/* Don't let a cast be an lvalue. */
if (value == expr)
if (lvalue_p (value))
value = non_lvalue_loc (loc, value);
/* Don't allow the results of casting to floating-point or complex

5
gcc/testsuite/ChangeLog
View file

@ -1,3 +1,8 @@
2015-06-04 Marek Polacek <polacek@redhat.com>
PR c/66341
* gcc.dg/lvalue-8.c: New test.
2015-06-03 Manuel López-Ibáñez <manu@gcc.gnu.org>
Paolo Carlini <paolo.carlini@oracle.com>

19
gcc/testsuite/gcc.dg/lvalue-8.c Normal file
View file

@ -0,0 +1,19 @@
/* PR c/66341 */
/* { dg-do compile } */
void
foo (int *p)
{
p = 0;
/* A cast does not yield an lvalue. */
(int *) p = 0; /* { dg-error "lvalue required as left operand of assignment" } */
/* A cast to a qualified type has the same effect as a cast
to the unqualified version of the type. */
(int *const) p = 0; /* { dg-error "lvalue required as left operand of assignment" } */
(int *) (char *) p = 0; /* { dg-error "lvalue required as left operand of assignment" } */
(int *) (char *) (int *) p = 0; /* { dg-error "lvalue required as left operand of assignment" } */
(int *) (char *) (int *) (char *) p = 0; /* { dg-error "lvalue required as left operand of assignment" } */
(int *) (double *) p = 0; /* { dg-error "lvalue required as left operand of assignment" } */
(int *) (int *) p = 0; /* { dg-error "lvalue required as left operand of assignment" } */
(int *) (int *const) p = 0; /* { dg-error "lvalue required as left operand of assignment" } */
}