procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gcov-profile: Allow negative counts of indirect calls [PR105282]

Browse source 
TOPN metrics are histograms that contain overall count and per-bucket
count. Overall count can be negative when two profiles merge and some
of per-bucket metrics are disacarded.

Noticed as an ICE on python PGO build where gcc crashes as:

    during IPA pass: modref
    a.c:36:1: ICE: in stream_out_histogram_value, at value-prof.cc:340
       36 | }
          | ^
    stream_out_histogram_value(output_block*, histogram_value_t*)
            gcc/value-prof.cc:340

gcc/ChangeLog:

	PR gcov-profile/105282
	* value-prof.cc (stream_out_histogram_value): Allow negative counts
	on HIST_TYPE_INDIR_CALL.
This commit is contained in:
Sergei Trofimovich 2022-04-15 08:35:27 +01:00
parent b85abacd90
commit 90a29845bf
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
gcc/value-prof.cc
View file

@ -336,6 +336,10 @@ stream_out_histogram_value (struct output_block *ob, histogram_value hist)
/* Note that the IOR counter tracks pointer values and these can have
sign bit set. */
;
else if (hist->type == HIST_TYPE_INDIR_CALL && i == 0)
/* 'all' counter overflow is stored as a negative value. Individual
counters and values are expected to be non-negative. */
;
else
gcc_assert (value >= 0);