procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

DSE: Fix ICE after allow vector type in get_stored_val

Browse source 
We allowed vector type for get_stored_val when read is less than or
equal to store in previous.  Unfortunately,  the valididate_subreg
treats the vector type's size is less than vector register as
invalid.  Then we will have ICE here.

This patch would like to fix it by filter-out the invalid type size,
and make sure the subreg is valid for both the read_mode and store_mode
before perform the real gen_lowpart.

The below test suites are passed for this patch:

* The x86 bootstrap test.
* The x86 regression test.
* The riscv rv64gcv regression test.
* The riscv rv64gc regression test.
* The aarch64 regression test.

gcc/ChangeLog:

	* dse.cc (get_stored_val): Make sure read_mode/write_mode
	is valid subreg before gen_lowpart.

gcc/testsuite/ChangeLog:

	* gcc.target/riscv/rvv/base/bug-6.c: New test.

Signed-off-by: Pan Li <pan2.li@intel.com>
This commit is contained in:
Pan Li 2024-04-30 09:42:39 +08:00
parent f22afbe0e0
commit 88b3f83238
2 changed files with 25 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
gcc/dse.cc
View file

@ -1946,7 +1946,9 @@ get_stored_val (store_info *store_info, machine_mode read_mode,
copy_rtx (store_info->const_rhs));
else if (VECTOR_MODE_P (read_mode) && VECTOR_MODE_P (store_mode)
&& known_le (GET_MODE_BITSIZE (read_mode), GET_MODE_BITSIZE (store_mode))
&& targetm.modes_tieable_p (read_mode, store_mode))
&& targetm.modes_tieable_p (read_mode, store_mode)
&& validate_subreg (read_mode, store_mode, copy_rtx (store_info->rhs),
subreg_lowpart_offset (read_mode, store_mode)))
read_reg = gen_lowpart (read_mode, copy_rtx (store_info->rhs));
else
read_reg = extract_low_bits (read_mode, store_mode,

22
gcc/testsuite/gcc.target/riscv/rvv/base/bug-6.c Normal file
View file

@ -0,0 +1,22 @@
/* Test that we do not have ice when compile */
/* { dg-do compile } */
/* { dg-options "-march=rv64gcv -mabi=lp64d -O3 -ftree-vectorize" } */
struct A { float x, y; };
struct B { struct A u; };
extern void bar (struct A *);
float
f3 (struct B *x, int y)
{
struct A p = {1.0f, 2.0f};
struct A *q = &x[y].u;
__builtin_memcpy (&q->x, &p.x, sizeof (float));
__builtin_memcpy (&q->y, &p.y, sizeof (float));
bar (&p);
return x[y].u.x + x[y].u.y;
}