procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Darwin: Make sanitizer local vars linker-visible.

Browse source 
Another case where we need a linker-visible symbols in order to
preserve the ld64 atom model.  If these symbols are emitted as
'local' the linker cannot see that they are separate from any
global weak entry that precedes them.  This will cause the linker
to complain that there is (apparently) direct access to such a
weak global, preventing it from being replaced.

This is a short-term fix for the problem - we need generic
handling for relevant cases (that also does not pessimise objects
by emitting unnecessary symbols and relocations).

gcc/ChangeLog:

2020-05-23  Iain Sandoe  <iain@sandoe.co.uk>

	* config/darwin.h (ASM_GENERATE_INTERNAL_LABEL):
	Make ubsan_{data,type},ASAN symbols linker-visible.
This commit is contained in:
Iain Sandoe 2020-05-23 08:25:10 +01:00
parent 33e09fc505
commit 804254edb4
2 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gcc/ChangeLog
View file

@ -1,3 +1,8 @@
2020-05-23 Iain Sandoe <iain@sandoe.co.uk>
* config/darwin.h (ASM_GENERATE_INTERNAL_LABEL): Make
ubsan_{data,type},ASAN symbols linker-visible.
2020-05-22 Jan Hubicka <hubicka@ucw.cz>
* lto-streamer-out.c (DFS::DFS): Silence warning.

6
gcc/config/darwin.h
View file

@ -808,6 +808,12 @@ extern GTY(()) section * darwin_sections[NUM_DARWIN_SECTIONS];
do { \
if (strcmp ("LC", PREFIX) == 0) \
sprintf (LABEL, "*%s%ld", "lC", (long)(NUM)); \
else if (strcmp ("Lubsan_data", PREFIX) == 0) \
sprintf (LABEL, "*%s%ld", "lubsan_data", (long)(NUM));\
else if (strcmp ("Lubsan_type", PREFIX) == 0) \
sprintf (LABEL, "*%s%ld", "lubsan_type", (long)(NUM));\
else if (strcmp ("LASAN", PREFIX) == 0) \
sprintf (LABEL, "*%s%ld", "lASAN", (long)(NUM));\
else \
sprintf (LABEL, "*%s%ld", PREFIX, (long)(NUM)); \
} while (0)