procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ipa-cp: Avoid ICE when redistributing nodes among edges to recursive clones (PR 118318)

Browse source 
PR 118318 reported an ICE during PGO build of Firefox when IPA-CP, in
the final stages of update_counts_for_self_gen_clones where it
attempts to guess how to distribute profile count among clones created
for recursive edges and the various edges that are created in the
process.  If one such edge has profile count of kind GUESSED_GLOBAL0,
the compatibility check in the operator+ will lead to an ICE.  After
discussing the situation with Honza, we concluded that there is little
more we can do other than check for this situation before touching the
edge count, so this is what this patch does.

gcc/ChangeLog:

2025-02-28  Martin Jambor  <mjambor@suse.cz>

	PR ipa/118318
	* ipa-cp.cc (adjust_clone_incoming_counts): Add a compatible_p check.
This commit is contained in:
Martin Jambor 2025-03-07 17:17:24 +01:00 • committed by Martin Jambor
parent b7f5d91148
commit 7deb498425
No known key found for this signature in database
GPG key ID: BF63C1BC3FA43540
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
gcc/ipa-cp.cc
View file

@ -4638,7 +4638,8 @@ adjust_clone_incoming_counts (cgraph_node *node,
cs->count = cs->count.combine_with_ipa_count (sum);
}
else if (!desc->processed_edges->contains (cs)
&& cs->caller->clone_of == desc->orig)
&& cs->caller->clone_of == desc->orig
&& cs->count.compatible_p (desc->count))
{
cs->count += desc->count;
if (dump_file)