procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

re PR c/89495 (gcc/c-family/c-format.c:1272:20: runtime error: signed integer overflow: 214748365 * 10 cannot be represented in type 'int')

Browse source 
PR c/89495
	* c-format.c (maybe_read_dollar_number): Compute nargnum in
	HOST_WIDE_INT type to avoid overflows and change overflow_flag
	checking.

From-SVN: r269198
This commit is contained in:
Jakub Jelinek 2019-02-26 00:43:51 +01:00 • committed by Jakub Jelinek
parent 7969545012
commit 7da73ba7ef
2 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
gcc/c-family/ChangeLog
View file

@ -1,3 +1,10 @@
2019-02-25 Jakub Jelinek <jakub@redhat.com>
PR c/89495
* c-format.c (maybe_read_dollar_number): Compute nargnum in
HOST_WIDE_INT type to avoid overflows and change overflow_flag
checking.
2019-02-22 Richard Biener <rguenther@suse.de>
* c-pch.c (no_checksum): Remove.

6
gcc/c-family/c-format.c
View file

@ -1268,9 +1268,9 @@ maybe_read_dollar_number (const char **format,
overflow_flag = 0;
while (ISDIGIT (*fcp))
{
int nargnum;
nargnum = 10 * argnum + (*fcp - '0');
if (nargnum < 0 || nargnum / 10 != argnum)
HOST_WIDE_INT nargnum
= HOST_WIDE_INT_UC (10) * argnum + (*fcp - '0');
if ((int) nargnum != nargnum)
overflow_flag = 1;
argnum = nargnum;
fcp++;