procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ada: Remove repeated guards in validity checks

Browse source 
Routine Insert_Valid_Check only applies checks when Expr_Known_Valid
query returns False; there is no need to call this query before
inserting checks.

Code cleanup; behavior is unaffected.

gcc/ada/

	* exp_imgv.adb (Expand_User_Defined_Enumeration_Image)
	(Expand_Image_Attribute): Remove redundant guards.
This commit is contained in:
Piotr Trojanek 2024-08-08 10:59:57 +02:00 • committed by Marc Poulhiès
parent 25d51fb7d0
commit 78acc6d85f
1 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
gcc/ada/exp_imgv.adb
View file

@ -896,9 +896,7 @@ package body Exp_Imgv is
-- Apply a validity check, since it is a bit drastic to get a
-- completely junk image value for an invalid value.
if not Expr_Known_Valid (Expr) then
Insert_Valid_Check (Expr);
end if;
Insert_Valid_Check (Expr);
-- Generate:
-- P1 : constant Natural := Typ'Pos (Typ?(Expr));
@ -1249,9 +1247,7 @@ package body Exp_Imgv is
-- Apply a validity check, since it is a bit drastic to get a
-- completely junk image value for an invalid value.
if not Expr_Known_Valid (Expr) then
Insert_Valid_Check (Expr);
end if;
Insert_Valid_Check (Expr);
Enum_Case := True;
end if;