procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

x86: Error on -fcf-protection with incompatible target

Browse source 
-fcf-protection with CF_BRANCH inserts ENDBR32 at function entries.
ENDBR32 is NOP only on 64-bit processors and 32-bit TARGET_CMOV
processors.  Issue an error for -fcf-protection with CF_BRANCH when
compiling for 32-bit non-TARGET_CMOV targets.

gcc/

	PR target/98667
	* config/i386/i386-options.c (ix86_option_override_internal):
	Issue an error for -fcf-protection with CF_BRANCH when compiling
	for 32-bit non-TARGET_CMOV targets.

gcc/testsuite/

	PR target/98667
	* gcc.target/i386/pr98667-1.c: New file.
	* gcc.target/i386/pr98667-2.c: Likewise.
	* gcc.target/i386/pr98667-3.c: Likewise.
This commit is contained in:
H.J. Lu 2021-01-14 05:56:46 -08:00
parent 5ebdd53534
commit 77d372abec
4 changed files with 32 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
gcc/config/i386/i386-options.c
View file

@ -3014,8 +3014,14 @@ ix86_option_override_internal (bool main_args_p,
}
if (opts->x_flag_cf_protection != CF_NONE)
opts->x_flag_cf_protection
{
if ((opts->x_flag_cf_protection & CF_BRANCH) == CF_BRANCH
&& !TARGET_64BIT && !TARGET_CMOV)
error ("%<-fcf-protection%> is not compatible with this target");
opts->x_flag_cf_protection
= (cf_protection_level) (opts->x_flag_cf_protection | CF_SET);
}
if (ix86_tune_features [X86_TUNE_AVOID_256FMA_CHAINS])
SET_OPTION_IF_UNSET (opts, opts_set, param_avoid_fma_max_bits, 256);

9
gcc/testsuite/gcc.target/i386/pr98667-1.c Normal file
View file

@ -0,0 +1,9 @@
/* { dg-do compile { target ia32 } } */
/* { dg-options "-O2 -fcf-protection -march=i486" } */
void
test (void)
{
}
/* { dg-error "'-fcf-protection' is not compatible with this target" "" { target *-*-* } 0 } */

9
gcc/testsuite/gcc.target/i386/pr98667-2.c Normal file
View file

@ -0,0 +1,9 @@
/* { dg-do compile { target ia32 } } */
/* { dg-options "-O2 -fcf-protection=branch -march=i486" } */
void
test (void)
{
}
/* { dg-error "'-fcf-protection' is not compatible with this target" "" { target *-*-* } 0 } */

7
gcc/testsuite/gcc.target/i386/pr98667-3.c Normal file
View file

@ -0,0 +1,7 @@
/* { dg-do compile { target ia32 } } */
/* { dg-options "-O2 -fcf-protection=return -march=i486" } */
void
test (void)
{
}