procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

rs6000: Fix vec_cpsgn parameter order (PR101985)

Browse source 
The vec_cpsgn built-in function API differs in argument order from the
copysign<mode>3 convention.  Currently that pattern is incorrctly used to
implement vec_cpsgn.  Fix that by reversing the operand order of the
builtin while leaving the existing pattern in place to implement copysignf
for vector modes.

Part of the fix when using the new built-in support requires an adjustment
to a pending patch that replaces much of altivec.h with an automatically
generated file.

Also fix a bug in the new built-in overload infrastructure where we were
using the VSX form of the VEC_COPYSIGN built-in when we should default to
the VMX form.

2021-10-12  Bill Schmidt  <wschmidt@linux.ibm.com>

gcc/
	PR target/101985
	* config/rs6000/altivec.h (vec_cpsgn): Swap operand order.
	* config/rs6000/rs6000-overload.def (VEC_COPYSIGN): Use SKIP to
	avoid generating an automatic #define of vec_cpsgn.  Use the
	correct built-in for V4SFmode that doesn't depend on VSX.

gcc/testsuite/
	PR target/101985
	* gcc.target/powerpc/pr101985-1.c: New.
	* gcc.target/powerpc/pr101985-2.c: New.
This commit is contained in:
Bill Schmidt 2021-10-12 17:37:16 -05:00
parent 4ca446a46b
commit 76ba473b99
4 changed files with 39 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
gcc/config/rs6000/altivec.h
View file

@ -129,7 +129,7 @@
#define vec_vcfux __builtin_vec_vcfux
#define vec_cts __builtin_vec_cts
#define vec_ctu __builtin_vec_ctu
#define vec_cpsgn __builtin_vec_copysign
#define vec_cpsgn(x,y) __builtin_vec_copysign(y,x)
#define vec_double __builtin_vec_double
#define vec_doublee __builtin_vec_doublee
#define vec_doubleo __builtin_vec_doubleo

4
gcc/config/rs6000/rs6000-overload.def
View file

@ -1154,9 +1154,9 @@
vus __builtin_vec_convert_4f32_8f16 (vf, vf);
CONVERT_4F32_8F16
[VEC_COPYSIGN, vec_cpsgn, __builtin_vec_copysign]
[VEC_COPYSIGN, SKIP, __builtin_vec_copysign]
vf __builtin_vec_copysign (vf, vf);
CPSGNSP
COPYSIGN_V4SF
vd __builtin_vec_copysign (vd, vd);
CPSGNDP

18
gcc/testsuite/gcc.target/powerpc/pr101985-1.c Normal file
View file

@ -0,0 +1,18 @@
/* PR target/101985 */
/* { dg-do run } */
/* { dg-require-effective-target vsx_hw } */
/* { dg-options "-O2 -mvsx" } */
#include <altivec.h>
int
main (void)
{
vector float a = { 1, 2, - 3, - 4};
vector float b = {-10, 20, -30, 40};
vector float c = { 10, 20, -30, -40};
a = vec_cpsgn (a, b);
if (! vec_all_eq (a, c))
__builtin_abort ();
return 0;
}

18
gcc/testsuite/gcc.target/powerpc/pr101985-2.c Normal file
View file

@ -0,0 +1,18 @@
/* PR target/101985 */
/* { dg-do run } */
/* { dg-require-effective-target vsx_hw } */
/* { dg-options "-O2 -mvsx" } */
#include <altivec.h>
int
main (void)
{
vector double a = { 1, -4};
vector double b = { -10, 40};
vector double c = { 10, -40};
a = vec_cpsgn (a, b);
if (! vec_all_eq (a, c))
__builtin_abort ();
return 0;
}