procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix PR c/94726: ICE with __builtin_shuffle and changing of types

Browse source 
The problem here is __builtin_shuffle when called with two arguments
instead of 1, uses a SAVE_EXPR to put in for the 1st and 2nd operand
of VEC_PERM_EXPR and when we go and gimplify the SAVE_EXPR, the type
is now error_mark_node and that fails hard.
This fixes the problem by adding a simple check for type of operand
of SAVE_EXPR not to be error_mark_node.

OK? Bootstrapped and tested on aarch64-linux-gnu with no regressions.

gcc/ChangeLog:

	PR c/94726
	* gimplify.c (gimplify_save_expr): Return early
	if the type of val is error_mark_node.

gcc/testsuite/ChangeLog:

	PR c/94726
	* gcc.dg/pr94726.c: New test.
This commit is contained in:
Andrew Pinski 2021-09-26 05:44:58 +00:00
parent d5f8abe1d3
commit 76773d3fea
2 changed files with 14 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
gcc/gimplify.c
View file

@ -6232,6 +6232,9 @@ gimplify_save_expr (tree *expr_p, gimple_seq *pre_p, gimple_seq *post_p)
gcc_assert (TREE_CODE (*expr_p) == SAVE_EXPR);
val = TREE_OPERAND (*expr_p, 0);
if (TREE_TYPE (val) == error_mark_node)
return GS_ERROR;
/* If the SAVE_EXPR has not been resolved, then evaluate it once. */
if (!SAVE_EXPR_RESOLVED_P (*expr_p))
{

11
gcc/testsuite/gcc.dg/pr94726.c Normal file
View file

@ -0,0 +1,11 @@
/* { dg-do compile } */
/* { dg-options "-O2" } */
typedef unsigned int type __attribute__ ( ( vector_size ( 2*sizeof(int) ) ) ) ;
type a , b;
/* { dg-message "note: previous declaration" "previous declaration" { target *-*-* } .-1 } */
void foo ( void ) {
type var = { 2 , 2 } ;
b = __builtin_shuffle ( a , var ) ;
}
void * a [ ] = { } ; /* { dg-error "conflicting types" } */