procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

aarch64: Preserve mem info on change of base for ldp/stp [PR114674]

Browse source 
The ldp/stp fusion pass can change the base of an access so that the two
accesses end up using a common base register.  So far we have been using
adjust_address_nv to do this, but this means that we don't preserve
other properties of the mem we're replacing.  It seems better to use
replace_equiv_address_nv, as this will preserve e.g. the MEM_ALIGN of the
mem whose address we're changing.

The PR shows that by adjusting the other mem we lose alignment
information about the original access and therefore end up rejecting an
otherwise viable pair when --param=aarch64-stp-policy=aligned is passed.
This patch fixes that by using replace_equiv_address_nv instead.

Notably this is the same approach as taken by
aarch64_check_consecutive_mems when a change of base is required, so
this at least makes things more consistent between the ldp fusion pass
and the peepholes.

gcc/ChangeLog:

	PR target/114674
	* config/aarch64/aarch64-ldp-fusion.cc (ldp_bb_info::fuse_pair):
	Use replace_equiv_address_nv on a change of base instead of
	adjust_address_nv on the other access.

gcc/testsuite/ChangeLog:

	PR target/114674
	* gcc.target/aarch64/pr114674.c: New test.
This commit is contained in:
Alex Coplan 2024-04-10 16:30:36 +01:00
parent bf10f0db20
commit 74690ff96b
2 changed files with 21 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
gcc/config/aarch64/aarch64-ldp-fusion.cc
View file

@ -1722,11 +1722,11 @@ ldp_bb_info::fuse_pair (bool load_p,
adjust_amt *= -1;
rtx change_reg = XEXP (change_pat, !load_p);
machine_mode mode_for_mem = GET_MODE (change_mem);
rtx effective_base = drop_writeback (base_mem);
rtx new_mem = adjust_address_nv (effective_base,
mode_for_mem,
adjust_amt);
rtx adjusted_addr = plus_constant (Pmode,
XEXP (effective_base, 0),
adjust_amt);
rtx new_mem = replace_equiv_address_nv (change_mem, adjusted_addr);
rtx new_set = load_p
? gen_rtx_SET (change_reg, new_mem)
: gen_rtx_SET (new_mem, change_reg);

17
gcc/testsuite/gcc.target/aarch64/pr114674.c Normal file
View file

@ -0,0 +1,17 @@
/* { dg-do compile } */
/* { dg-options "-O3 --param=aarch64-stp-policy=aligned" } */
typedef struct {
unsigned int f1;
unsigned int f2;
} test_struct;
static test_struct ts = {
123, 456
};
void foo(void)
{
ts.f2 = 36969 * (ts.f2 & 65535) + (ts.f1 >> 16);
ts.f1 = 18000 * (ts.f2 & 65535) + (ts.f2 >> 16);
}
/* { dg-final { scan-assembler-times "stp" 1 } } */