From 72c9526d3dc0742ee9a5f5cc4f90bf3375fb0bba Mon Sep 17 00:00:00 2001 From: Ilya Enkovich Date: Tue, 22 Mar 2016 19:00:14 +0000 Subject: [PATCH] re PR target/70302 (crash on valid code at -O2 and -O3 in 32-bit mode on x86_64-linux-gnu (in convert_op, at config/i386/i386.c:3414)) 2016-03-22 Ilya Enkovich PR target/70302 * config/i386/i386.c (scalar_chain::convert_op): Support uninitialized register usage case. PR target/70302 * gcc.target/i386/pr70302.c: New test. From-SVN: r234406 --- gcc/ChangeLog | 6 ++++++ gcc/config/i386/i386.c | 14 ++++++++++++++ gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/gcc.target/i386/pr70302.c | 22 ++++++++++++++++++++++ 4 files changed, 47 insertions(+) create mode 100644 gcc/testsuite/gcc.target/i386/pr70302.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 92391efd907..68484965cd7 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2016-03-22 Ilya Enkovich + + PR target/70302 + * config/i386/i386.c (scalar_chain::convert_op): Support + uninitialized register usage case. + 2016-03-22 Richard Biener PR middle-end/70251 diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index f32583168c4..1639704835b 100644 --- a/gcc/config/i386/i386.c +++ b/gcc/config/i386/i386.c @@ -3409,6 +3409,20 @@ scalar_chain::convert_op (rtx *op, rtx_insn *insn) fprintf (dump_file, " Preloading operand for insn %d into r%d\n", INSN_UID (insn), REGNO (tmp)); } + else if (REG_P (*op)) + { + /* We may have not converted register usage in case + this register has no definition. Otherwise it + should be converted in convert_reg. */ + df_ref ref; + FOR_EACH_INSN_USE (ref, insn) + if (DF_REF_REGNO (ref) == REGNO (*op)) + { + gcc_assert (!DF_REF_CHAIN (ref)); + break; + } + *op = gen_rtx_SUBREG (V2DImode, *op, 0); + } else { gcc_assert (SUBREG_P (*op)); diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 00c82625bef..43217b8c476 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2016-03-22 Ilya Enkovich + + PR target/70302 + * gcc.target/i386/pr70302.c: New test. + 2016-03-22 Richard Biener PR middle-end/70251 diff --git a/gcc/testsuite/gcc.target/i386/pr70302.c b/gcc/testsuite/gcc.target/i386/pr70302.c new file mode 100644 index 00000000000..9b82a0c4509 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr70302.c @@ -0,0 +1,22 @@ +/* { dg-do compile { target { ia32 } } } */ +/* { dg-options "-O2 -msse2" } */ + +long a, c, e; +int b, d; +unsigned long long f; + +extern void fn2 (const char *, int, int, int); + +void +fn1(long long p1) +{ + unsigned long long g; + int i; + for (; i;) + if (e) + g = c; + if (a) + f = p1; + if (!f && !g) + fn2("", b, d, d); +}