From 7258a2576581f90c5ba8399e6f6ba6c36a16ff86 Mon Sep 17 00:00:00 2001 From: Jakub Jelinek Date: Fri, 15 Aug 2014 12:23:13 +0200 Subject: [PATCH] re PR fortran/62131 (OpenMP: Subobject of an allocatable array not allowed in OMP ATOMIC) PR fortran/62131 * openmp.c (resolve_omp_atomic): Only complain if code->expr1's attr is allocatable, rather than whenever var->attr.allocatable. * gfortran.dg/gomp/pr62131.f90: New test. Co-Authored-By: Tobias Burnus From-SVN: r214010 --- gcc/fortran/ChangeLog | 7 +++++++ gcc/fortran/openmp.c | 2 +- gcc/testsuite/ChangeLog | 6 ++++++ gcc/testsuite/gfortran.dg/gomp/pr62131.f90 | 19 +++++++++++++++++++ 4 files changed, 33 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gfortran.dg/gomp/pr62131.f90 diff --git a/gcc/fortran/ChangeLog b/gcc/fortran/ChangeLog index f6e3082d1c6..411fe4c8f50 100644 --- a/gcc/fortran/ChangeLog +++ b/gcc/fortran/ChangeLog @@ -1,3 +1,10 @@ +2014-08-15 Jakub Jelinek + Tobias Burnus + + PR fortran/62131 + * openmp.c (resolve_omp_atomic): Only complain if code->expr1's attr + is allocatable, rather than whenever var->attr.allocatable. + 2014-08-15 Jakub Jelinek PR fortran/62107 diff --git a/gcc/fortran/openmp.c b/gcc/fortran/openmp.c index 49c3b9e86c1..217fce73828 100644 --- a/gcc/fortran/openmp.c +++ b/gcc/fortran/openmp.c @@ -2744,7 +2744,7 @@ resolve_omp_atomic (gfc_code *code) break; } - if (var->attr.allocatable) + if (gfc_expr_attr (code->expr1).allocatable) { gfc_error ("!$OMP ATOMIC with ALLOCATABLE variable at %L", &code->loc); diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index ab8e0544302..505df55667c 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2014-08-15 Jakub Jelinek + Tobias Burnus + + PR fortran/62131 + * gfortran.dg/gomp/pr62131.f90: New test. + 2014-08-15 Richard Biener PR tree-optimization/62031 diff --git a/gcc/testsuite/gfortran.dg/gomp/pr62131.f90 b/gcc/testsuite/gfortran.dg/gomp/pr62131.f90 new file mode 100644 index 00000000000..8e88cd70bcc --- /dev/null +++ b/gcc/testsuite/gfortran.dg/gomp/pr62131.f90 @@ -0,0 +1,19 @@ +! PR fortran/62131 +! { dg-do compile } +! { dg-options "-fopenmp" } + +program pr62131 + integer,allocatable :: nerrs(:,:) + allocate(nerrs(10,10)) + nerrs(:,:) = 0 +!$omp parallel do + do k=1,10 + call uperrs(k,1) + end do +contains + subroutine uperrs(i,io) + integer,intent(in) :: i,io +!$omp atomic + nerrs(i,io)=nerrs(i,io)+1 + end subroutine +end