procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

libstdc++: Add assertion to std::string_view::remove_suffix [PR112314]

Browse source 
libstdc++-v3/ChangeLog:

	PR libstdc++/112314
	* include/std/string_view (string_view::remove_suffix): Add
	debug assertion.
	* testsuite/21_strings/basic_string_view/modifiers/remove_prefix/debug.cc:
	New test.
	* testsuite/21_strings/basic_string_view/modifiers/remove_suffix/debug.cc:
	New test.
This commit is contained in:
Jonathan Wakely 2023-11-01 15:01:22 +00:00
parent f432a594fe
commit 6afa984f47
3 changed files with 32 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
libstdc++-v3/include/std/string_view
View file

@ -301,7 +301,10 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
constexpr void
remove_suffix(size_type __n) noexcept
{ this->_M_len -= __n; }
{
__glibcxx_assert(this->_M_len >= __n);
this->_M_len -= __n;
}
constexpr void
swap(basic_string_view& __sv) noexcept

14
libstdc++-v3/testsuite/21_strings/basic_string_view/modifiers/remove_prefix/debug.cc Normal file
View file

@ -0,0 +1,14 @@
// { dg-do compile { target c++17 } }
#include <string_view>
constexpr bool
check_remove_prefix()
{
std::string_view sv("123");
sv.remove_prefix(4);
// { dg-error "not a constant expression" "" { target *-*-* } 0 }
return true;
}
constexpr bool test = check_remove_prefix();

14
libstdc++-v3/testsuite/21_strings/basic_string_view/modifiers/remove_suffix/debug.cc Normal file
View file

@ -0,0 +1,14 @@
// { dg-do compile { target c++17 } }
#include <string_view>
constexpr bool
check_remove_suffix()
{
std::string_view sv("123");
sv.remove_suffix(4);
// { dg-error "not a constant expression" "" { target *-*-* } 0 }
return true;
}
constexpr bool test = check_remove_suffix();