procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

c-family: Fix ICE with -Wsuggest-attribute [PR98487]

Browse source 
Here we crash because check_function_format was using TREE_PURPOSE
directly rather than using get_attribute_name.

	PR c/98487

gcc/c-family/ChangeLog:

	* c-format.cc (check_function_format): Use get_attribute_name.

gcc/testsuite/ChangeLog:

	* c-c++-common/Wsuggest-attribute-1.c: New test.
This commit is contained in:
Marek Polacek 2022-12-16 12:28:43 -05:00
parent 263c22a95b
commit 68e51bd0a8
2 changed files with 37 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
gcc/c-family/c-format.cc
View file

@ -1215,7 +1215,7 @@ check_function_format (const_tree fn, tree attrs, int nargs,
for (c = TYPE_ATTRIBUTES (TREE_TYPE (current_function_decl));
c;
c = TREE_CHAIN (c))
if (is_attribute_p ("format", TREE_PURPOSE (c))
if (is_attribute_p ("format", get_attribute_name (c))
&& (decode_format_type (IDENTIFIER_POINTER
(TREE_VALUE (TREE_VALUE (c))))
== info.format_type))

36
gcc/testsuite/c-c++-common/Wsuggest-attribute-1.c Normal file
View file

@ -0,0 +1,36 @@
/* PR c/98487 */
/* { dg-do compile { target { c || c++11 } } } */
/* { dg-options "-Wsuggest-attribute=format" } */
#include <stdarg.h>
[[gnu::__format__(__printf__, 1, 2)]]
void
do_printf(const char * const a0, ...)
{
va_list ap;
va_start(ap, a0);
__builtin_vprintf(a0, ap);
va_end(ap);
}
[[gnu::__format__(__scanf__, 1, 2)]]
void
do_scanf(const char * const a0, ...)
{
va_list ap;
va_start(ap, a0);
__builtin_vscanf(a0, ap);
va_end(ap);
}
struct tm;
[[gnu::__format__(__strftime__, 1, 0)]]
void
do_strftime(const char * const a0, struct tm * a1)
{
char buff[256];
__builtin_strftime(buff, sizeof(buff), a0, a1);
__builtin_puts(buff);
}