procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add warning Wenum-conversion for C and ObjC.

Browse source 
The patch enables warning with Wextra due to PR91593 and warnings with
allmodconfig kernel build. Once these issues are resolved, we could
consider promoting it to Wall.

2019-09-04  Prathamesh Kulkarni  <prathamesh.kulkarni@linaro.org>

	PR c/78736
	* doc/invoke.texi: Document -Wenum-conversion.

c-family
	* c.opt (Wenum-conversion): New option.

c/
	* c-typeck.c (convert_for_assignment): Handle Wenum-conversion.

testsuite/
	* gcc.dg/Wenum-conversion.c: New test-case.

From-SVN: r275376
This commit is contained in:
Prathamesh Kulkarni 2019-09-04 16:25:21 +00:00 • committed by Prathamesh Kulkarni
parent bc7f7ff954
commit 68e2c1996e
8 changed files with 68 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gcc/ChangeLog
View file

@ -1,3 +1,8 @@
2019-09-04 Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>
PR c/78736
* doc/invoke.texi: Document -Wenum-conversion.
2019-09-04 Richard Biener <rguenther@suse.de>
PR rtl-optimization/36262

5
gcc/c-family/ChangeLog
View file

@ -1,3 +1,8 @@
2019-09-04 Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>
PR c/78736
* c.opt (Wenum-conversion): New option.
2019-09-03 Jozef Lawrynowicz <jozef.l@mittosystems.com>
* c-attribs.c (handle_section_attribute): Call the

4
gcc/c-family/c.opt
View file

@ -541,6 +541,10 @@ Wenum-compare
C ObjC C++ ObjC++ Var(warn_enum_compare) Init(-1) Warning LangEnabledBy(C ObjC,Wall || Wc++-compat)
Warn about comparison of different enum types.
Wenum-conversion
C ObjC Var(warn_enum_conversion) Init(0) Warning LangEnabledBy(C ObjC,Wextra)
Warn about implicit conversion of enum types.
Werror
C ObjC C++ ObjC++
; Documented in common.opt

5
gcc/c/ChangeLog
View file

@ -1,3 +1,8 @@
2019-09-04 Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>
PR c/78736
* c-typeck.c (convert_for_assignment): Handle Wenum-conversion.
2019-08-23 Iain Sandoe <iain@sandoe.co.uk>
PR pch/61250

15
gcc/c/c-typeck.c
View file

@ -6726,6 +6726,21 @@ convert_for_assignment (location_t location, location_t expr_loc, tree type,
}
}
if (warn_enum_conversion)
{
tree checktype = origtype != NULL_TREE ? origtype : rhstype;
if (checktype != error_mark_node
&& TREE_CODE (checktype) == ENUMERAL_TYPE
&& TREE_CODE (type) == ENUMERAL_TYPE
&& TYPE_MAIN_VARIANT (checktype) != TYPE_MAIN_VARIANT (type))
{
gcc_rich_location loc (location);
warning_at (&loc, OPT_Wenum_conversion,
"implicit conversion from %qT to %qT",
checktype, type);
}
}
if (TYPE_MAIN_VARIANT (type) == TYPE_MAIN_VARIANT (rhstype))
{
warn_for_address_or_pointer_of_packed_member (type, orig_rhs);

10
gcc/doc/invoke.texi
View file

@ -307,7 +307,8 @@ Objective-C and Objective-C++ Dialects}.
-Wno-discarded-qualifiers -Wno-discarded-array-qualifiers @gol
-Wno-div-by-zero -Wdouble-promotion @gol
-Wduplicated-branches -Wduplicated-cond @gol
-Wempty-body -Wenum-compare -Wno-endif-labels -Wexpansion-to-defined @gol
-Wempty-body -Wenum-compare -Wenum-conversion @gol
-Wno-endif-labels -Wexpansion-to-defined @gol
-Werror -Werror=* -Wextra-semi -Wfatal-errors @gol
-Wfloat-equal -Wformat -Wformat=2 @gol
-Wno-format-contains-nul -Wno-format-extra-args @gol
@ -4434,6 +4435,7 @@ Options} and @ref{Objective-C and Objective-C++ Dialect Options}.
-Wcomment @gol
-Wduplicate-decl-specifier @r{(C and Objective-C only)} @gol
-Wenum-compare @r{(in C/ObjC; this is on by default in C++)} @gol
-Wenum-conversion @r{in C/ObjC;} @gol
-Wformat @gol
-Wint-in-bool-context @gol
-Wimplicit @r{(C and Objective-C only)} @gol
@ -7012,6 +7014,12 @@ In C++ enumerated type mismatches in conditional expressions are also
diagnosed and the warning is enabled by default. In C this warning is
enabled by @option{-Wall}.
@item -Wenum-conversion @r{(C, Objective-C only)}
@opindex Wenum-conversion
@opindex Wno-enum-conversion
Warn when a value of enumerated type is implicitly converted to a
different enumerated type. This warning is enabled by @option{-Wextra}.
@item -Wextra-semi @r{(C++, Objective-C++ only)}
@opindex Wextra-semi
@opindex Wno-extra-semi

5
gcc/testsuite/ChangeLog
View file

@ -1,3 +1,8 @@
2019-09-04 Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>
PR c/78736
* gcc.dg/Wenum-conversion.c: New test-case.
2019-09-03 Jozef Lawrynowicz <jozef.l@mittosystems.com>
* gcc.target/msp430/data-attributes-2.c: New test.

20
gcc/testsuite/gcc.dg/Wenum-conversion.c Normal file
View file

@ -0,0 +1,20 @@
/* { dg-do compile } */
/* { dg-options "-Wenum-conversion" } */
enum X { x1, x2 };
enum Y { y1, y2 };
enum X obj = y1; /* { dg-warning "implicit conversion from .enum Y. to .enum X." } */
enum Y obj2 = y1;
enum X obj3;
void foo()
{
obj3 = y2; /* { dg-warning "implicit conversion from .enum Y. to .enum X." } */
}
void bar(enum X);
void f(void)
{
bar (y1); /* { dg-warning "implicit conversion from .enum Y. to .enum X." } */
}