procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

re PR tree-optimization/51528 (SRA should not create BOOLEAN_TYPE replacements)

Browse source 
2012-01-31  Richard Guenther  <rguenther@suse.de>

	PR tree-optimization/51528
	* tree-sra.c (sra_modify_assign): Avoid copy-in/out for aggregate
	assigns.

	* gcc.dg/torture/pr51528.c: New testcase.

From-SVN: r183752
This commit is contained in:
Richard Guenther 2012-01-31 09:46:29 +00:00 • committed by Richard Biener
parent 68c8a82477
commit 63d7ceaaba
4 changed files with 64 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gcc/ChangeLog
View file

@ -1,3 +1,9 @@
2012-01-31 Richard Guenther <rguenther@suse.de>
PR tree-optimization/51528
* tree-sra.c (sra_modify_assign): Avoid copy-in/out for aggregate
assigns.
2012-01-31 Jakub Jelinek <jakub@redhat.com>
PR bootstrap/52041

5
gcc/testsuite/ChangeLog
View file

@ -1,3 +1,8 @@
2012-01-31 Richard Guenther <rguenther@suse.de>
PR tree-optimization/51528
* gcc.dg/torture/pr51528.c: New testcase.
2012-01-30 Uros Bizjak <ubizjak@gmail.com>
PR go/48501

46
gcc/testsuite/gcc.dg/torture/pr51528.c Normal file
View file

@ -0,0 +1,46 @@
/* { dg-do run } */
/* { dg-options "-fno-early-inlining" } */
extern void abort (void);
union U
{
int i;
_Bool b;
};
_Bool gb;
void __attribute__ ((noinline))
use_bool (union U u)
{
gb = u.b;
}
union U
bar (void)
{
union U u;
u.i = 0xFFFE;
return u;
}
union U __attribute__ ((noinline))
foo (void)
{
union U u,v;
u.b = 1;
use_bool (u);
u = bar ();
return u;
}
int main (int argc, char **argv)
{
union U u = foo ();
if (u.i != 0xFFFE)
abort ();
return 0;
}

9
gcc/tree-sra.c
View file

@ -3135,9 +3135,14 @@ sra_modify_assign (gimple *stmt, gimple_stmt_iterator *gsi)
sra_stats.deleted++;
return SRA_AM_REMOVED;
}
/* Restore the aggregate RHS from its components so the
prevailing aggregate copy does the right thing. */
if (access_has_children_p (racc))
generate_subtree_copies (racc->first_child, lhs, racc->offset,
0, 0, gsi, false, true, loc);
generate_subtree_copies (racc->first_child, racc->base, 0, 0, 0,
gsi, false, false, loc);
/* Re-load the components of the aggregate copy destination.
But use the RHS aggregate to load from to expose more
optimization opportunities. */
if (access_has_children_p (lacc))
generate_subtree_copies (lacc->first_child, rhs, lacc->offset,
0, 0, gsi, true, true, loc);