procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

core: add tree-node comments

Browse source 
As we've moved to 64-bit systems, the padding information has become
conditionally inaccurate.  I also hit cases where invalid tree codes
did not get flagged as invalid.

	gcc/
	* tree-core.h (tree_decl_with_vis, tree_function_decl):
	Note additional padding on 64-bits
	* tree.c (cache_integer_cst): Note why no caching of enum literals.
	(get_tree_code_name): Robustify error case.
This commit is contained in:
Nathan Sidwell 2020-07-13 13:52:03 -07:00
parent 5ed9a5d02f
commit 6039cb96d1
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
gcc/tree-core.h
View file

@ -1826,6 +1826,7 @@ struct GTY(()) tree_decl_with_vis {
/* Belong to FUNCTION_DECL exclusively. */
unsigned regdecl_flag : 1;
/* 14 unused bits. */
/* 32 more unused on 64 bit HW. */
};
struct GTY(()) tree_var_decl {
@ -1901,6 +1902,7 @@ struct GTY(()) tree_function_decl {
unsigned replaceable_operator : 1;
/* 11 bits left for future expansion. */
/* 32 bits on 64-bit HW. */
};
struct GTY(()) tree_translation_unit_decl {

6
gcc/tree.c
View file

@ -1771,6 +1771,8 @@ cache_integer_cst (tree t)
break;
case ENUMERAL_TYPE:
/* The slot used by TYPE_CACHED_VALUES is used for the enum
members. */
break;
default:
@ -13254,7 +13256,9 @@ get_tree_code_name (enum tree_code code)
{
const char *invalid = "<invalid tree code>";
if (code >= MAX_TREE_CODES)
/* The tree_code enum promotes to signed, but we could be getting
invalid values, so force an unsigned comparison. */
if (unsigned (code) >= MAX_TREE_CODES)
{
if (code == 0xa5a5)
return "ggc_freed";