From 6017aed3043a62f0cc5f0e20804fd0913addc6be Mon Sep 17 00:00:00 2001 From: Iain Sandoe Date: Wed, 15 Feb 2012 19:17:42 +0000 Subject: [PATCH] re PR libitm/52042 (libitm.c/clone-1.c (all darwin) and libitm.c/stackundo.c (darwin 11) execution tests fail with -fpie) 2012-02-15 Iain Sandoe Patrick Marlier PR libitm/52042 * config/darwin-crt-tm.c (getTMCloneTable): New function. (__doTMRegistrations): Call it. (__doTMdeRegistrations): Likewise. Co-Authored-By: Patrick Marlier From-SVN: r184281 --- libgcc/ChangeLog | 8 ++++ libgcc/config/darwin-crt-tm.c | 76 ++++++++++++++++++++++++----------- 2 files changed, 60 insertions(+), 24 deletions(-) diff --git a/libgcc/ChangeLog b/libgcc/ChangeLog index 8219423a064..ff5101a7136 100644 --- a/libgcc/ChangeLog +++ b/libgcc/ChangeLog @@ -1,3 +1,11 @@ +2012-02-15 Iain Sandoe + Patrick Marlier + + PR libitm/52042 + * config/darwin-crt-tm.c (getTMCloneTable): New function. + (__doTMRegistrations): Call it. + (__doTMdeRegistrations): Likewise. + 2012-01-15 Georg-Johann Lay Anatoly Sokolov Eric Weddington diff --git a/libgcc/config/darwin-crt-tm.c b/libgcc/config/darwin-crt-tm.c index 23113374eea..78053f659a8 100644 --- a/libgcc/config/darwin-crt-tm.c +++ b/libgcc/config/darwin-crt-tm.c @@ -23,33 +23,67 @@ a copy of the GCC Runtime Library Exception along with this program; see the files COPYING3 and COPYING.RUNTIME respectively. If not, see . */ +#include "tsystem.h" +#include +#include #include +#include -/* not listed in mach-o/dyld.h for some reason. */ -extern char * getsectdata (const char*,const char*,unsigned long*); +#ifdef __LP64__ +#define GET_DATA_TMCT(mh,size) \ + getsectdatafromheader_64 ((struct mach_header_64*) mh, \ + "__DATA", "__tm_clone_table", (uint64_t *)size) +#else +#define GET_DATA_TMCT(mh,size) \ + getsectdatafromheader (mh, "__DATA", "__tm_clone_table", (uint32_t *)size) +#endif #define WEAK __attribute__((weak)) extern void _ITM_registerTMCloneTable (void *, size_t) WEAK; extern void _ITM_deregisterTMCloneTable (void *) WEAK; +#if defined(START) || defined(END) +static inline void *getTMCloneTable (const void *f, size_t *tmct_siz) +{ + char *tmct_fixed, *tmct = NULL; + unsigned int i, img_count; + struct mach_header *mh; + Dl_info info; + + if (! dladdr (f, &info) || info.dli_fbase == NULL) + abort (); + + mh = (struct mach_header *) info.dli_fbase; + tmct_fixed = GET_DATA_TMCT (mh, tmct_siz); + *tmct_siz /= (sizeof (size_t) * 2); + /* No tm_clone_table or no clones. */ + if (tmct_fixed == NULL || *tmct_siz == 0) + return NULL; + + img_count = _dyld_image_count(); + for (i = 0; i < img_count && tmct == NULL; i++) + { + if (mh == _dyld_get_image_header(i)) + tmct = tmct_fixed + (unsigned long)_dyld_get_image_vmaddr_slide(i); + } + + return tmct; +} +#endif + #ifdef START void __doTMRegistrations (void) __attribute__ ((constructor)); void __doTMRegistrations (void) { - char * tm_clone_table_sect_data; - unsigned long tmct_siz; - - tm_clone_table_sect_data = getsectdata ("__DATA", - "__tm_clone_table", - &tmct_siz); - tmct_siz /= (sizeof (size_t) * 2); - if (_ITM_registerTMCloneTable != NULL - && tm_clone_table_sect_data != NULL - && tmct_siz > 0) - _ITM_registerTMCloneTable (tm_clone_table_sect_data, (size_t)tmct_siz); + size_t tmct_siz; + void *tmct; + + tmct = getTMCloneTable ((const void *)&__doTMRegistrations, &tmct_siz); + if (_ITM_registerTMCloneTable != NULL && tmct != NULL) + _ITM_registerTMCloneTable (tmct, (size_t)tmct_siz); } #endif @@ -60,18 +94,12 @@ void __doTMdeRegistrations (void) __attribute__ ((destructor)); void __doTMdeRegistrations (void) { - char * tm_clone_table_sect_data; - unsigned long tmct_siz; - - tm_clone_table_sect_data = getsectdata ("__DATA", - "__tm_clone_table", - &tmct_siz); - - if (_ITM_deregisterTMCloneTable != NULL - && tm_clone_table_sect_data != NULL - && tmct_siz > 0) - _ITM_deregisterTMCloneTable (tm_clone_table_sect_data); + size_t tmct_siz; + void *tmct; + tmct = getTMCloneTable ((const void *)&__doTMdeRegistrations, &tmct_siz); + if (_ITM_deregisterTMCloneTable != NULL && tmct != NULL) + _ITM_deregisterTMCloneTable (tmct); } #endif