procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fortran: reject SAVE of a COMMON in a BLOCK construct [PR119199]

Browse source 
PR fortran/119199

gcc/fortran/ChangeLog:

	* decl.cc (gfc_match_save): Reject SAVE statement of a COMMON block
	when in a BLOCK construct.
	* trans-common.cc (translate_common): Avoid NULL pointer dereference.

gcc/testsuite/ChangeLog:

	* gfortran.dg/common_30.f90: New test.
	* gfortran.dg/common_31.f90: New test.
This commit is contained in:
Harald Anlauf 2025-03-10 22:24:27 +01:00
parent 0920568005
commit 5e9f71254a
4 changed files with 35 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
gcc/fortran/decl.cc
View file

@ -9795,6 +9795,15 @@ gfc_match_save (void)
if (m == MATCH_NO)
goto syntax;
/* F2023:C1108: A SAVE statement in a BLOCK construct shall contain a
saved-entity-list that does not specify a common-block-name. */
if (gfc_current_state () == COMP_BLOCK)
{
gfc_error ("SAVE of COMMON block %qs at %C is not allowed "
"in a BLOCK construct", n);
return MATCH_ERROR;
}
c = gfc_get_common (n, 0);
c->saved = 1;

2
gcc/fortran/trans-common.cc
View file

@ -1218,7 +1218,7 @@ translate_common (gfc_common_head *common, gfc_symbol *var_list)
align = 1;
saw_equiv = false;
if (var_list->attr.omp_allocate)
if (var_list && var_list->attr.omp_allocate)
gfc_error ("Sorry, !$OMP allocate for COMMON block variable %qs at %L "
"not supported", common->name, &common->where);

10
gcc/testsuite/gfortran.dg/common_30.f90 Normal file
View file

@ -0,0 +1,10 @@
! { dg-do compile }
! PR fortran/119199
!
! One cannot SAVE an undefined COMMON block
!
! Contributed by David Binderman
program main
save /argmnt1/ ! { dg-error "does not exist" }
end

15
gcc/testsuite/gfortran.dg/common_31.f90 Normal file
View file

@ -0,0 +1,15 @@
! { dg-do compile }
! PR fortran/119199 - reject SAVE of a COMMON in a BLOCK construct
!
! F2023:C1108: A SAVE statement in a BLOCK construct shall contain a
! saved-entity-list that does not specify a common-block-name.
!
! Contributed by David Binderman
program main
real r
common /argmnt2/ r
block
save /argmnt2/ ! { dg-error "not allowed in a BLOCK construct" }
end block
end