procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

re PR sanitizer/63520 (ICE: in get_biv_step, at loop-iv.c:824 with -fsanitize=undefined on ppc64)

Browse source 
PR sanitizer/63520
	* internal-fn.c (expand_ubsan_result_store): New function.
	(expand_addsub_overflow, expand_neg_overflow, expand_mul_overflow):
	Use it instead of just emit_move_insn.

	* c-c++-common/ubsan/pr63520.c: New test.

From-SVN: r217758
This commit is contained in:
Jakub Jelinek 2014-11-19 10:49:18 +01:00 • committed by Jakub Jelinek
parent a2a2fe4bfa
commit 5620052d3d
4 changed files with 46 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
gcc/ChangeLog
View file

@ -1,3 +1,10 @@
2014-11-19 Jakub Jelinek <jakub@redhat.com>
PR sanitizer/63520
* internal-fn.c (expand_ubsan_result_store): New function.
(expand_addsub_overflow, expand_neg_overflow, expand_mul_overflow):
Use it instead of just emit_move_insn.
2014-11-19 Richard Biener <rguenther@suse.de>
PR tree-optimization/63844

21
gcc/internal-fn.c
View file

@ -395,6 +395,21 @@ expand_arith_overflow_result_store (tree lhs, rtx target,
write_complex_part (target, lres, false);
}
/* Helper for expand_*_overflow. Store RES into TARGET. */
static void
expand_ubsan_result_store (rtx target, rtx res)
{
if (GET_CODE (target) == SUBREG && SUBREG_PROMOTED_VAR_P (target))
/* If this is a scalar in a register that is stored in a wider mode
than the declared mode, compute the result into its declared mode
and then convert to the wider mode. Our value is the computed
expression. */
convert_move (SUBREG_REG (target), res, SUBREG_PROMOTED_SIGN (target));
else
emit_move_insn (target, res);
}
/* Add sub/add overflow checking to the statement STMT.
CODE says whether the operation is +, or -. */
@ -809,7 +824,7 @@ expand_addsub_overflow (location_t loc, tree_code code, tree lhs,
if (lhs)
{
if (is_ubsan)
emit_move_insn (target, res);
expand_ubsan_result_store (target, res);
else
{
if (do_xor)
@ -904,7 +919,7 @@ expand_neg_overflow (location_t loc, tree lhs, tree arg1, bool is_ubsan)
if (lhs)
{
if (is_ubsan)
emit_move_insn (target, res);
expand_ubsan_result_store (target, res);
else
expand_arith_overflow_result_store (lhs, target, mode, res);
}
@ -1590,7 +1605,7 @@ expand_mul_overflow (location_t loc, tree lhs, tree arg0, tree arg1,
if (lhs)
{
if (is_ubsan)
emit_move_insn (target, res);
expand_ubsan_result_store (target, res);
else
expand_arith_overflow_result_store (lhs, target, mode, res);
}

5
gcc/testsuite/ChangeLog
View file

@ -1,3 +1,8 @@
2014-11-19 Jakub Jelinek <jakub@redhat.com>
PR sanitizer/63520
* c-c++-common/ubsan/pr63520.c: New test.
2014-11-19 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/57654

16
gcc/testsuite/c-c++-common/ubsan/pr63520.c Normal file
View file

@ -0,0 +1,16 @@
/* PR sanitizer/63520 */
/* { dg-do compile } */
/* { dg-options "-fsanitize=undefined" } */
int a;
void
foo (void)
{
while (1)
{
if (a == 1)
break;
a -= 1;
}
}