procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

re PR rtl-optimization/87761 ([MIPS] New FAIL: gcc.target/mips/fix-r4000-10.c -O1 start with r265398)

Browse source 
PR rtl-optimization/87761
	PR rtl-optimization/89826
	* regcprop.c (copyprop_hardreg_forward_1): Move may_trap_p test
	slightly later.
	(pass_cprop_hardreg::execute): Call df_analyze after adding the
	note problem to get REG_DEAD/REG_UNUSED notes updated.

	PR rtl-optimization/87761
	PR rtl-optimization/89826
	* gcc.c-torture/execute/pr89826.c: New test.

From-SVN: r269967
This commit is contained in:
Jeff Law 2019-03-27 10:18:06 -06:00 • committed by Jeff Law
parent ce4609958f
commit 52295c2de4
4 changed files with 41 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
gcc/ChangeLog
View file

@ -1,3 +1,13 @@
2019-03-27 Jeff Law <law@redhat.com>
PR rtl-optimization/87761
PR rtl-optimization/89826
* regcprop.c (copyprop_hardreg_forward_1): Move may_trap_p test
slightly later.
(pass_cprop_hardreg::execute): Call df_analyze after adding the
note problem to get REG_DEAD/REG_UNUSED notes updated.
2019-03-27 Richard Biener <rguenther@suse.de>
PR tree-optimization/89463

5
gcc/regcprop.c
View file

@ -800,9 +800,9 @@ copyprop_hardreg_forward_1 (basic_block bb, struct value_data *vd)
/* Detect obviously dead sets (via REG_UNUSED notes) and remove them. */
if (set
&& !may_trap_p (set)
&& !RTX_FRAME_RELATED_P (insn)
&& INSN_P (insn)
&& !may_trap_p (set)
&& find_reg_note (insn, REG_UNUSED, SET_DEST (set))
&& !side_effects_p (SET_SRC (set))
&& !side_effects_p (SET_DEST (set)))
@ -1293,7 +1293,10 @@ pass_cprop_hardreg::execute (function *fun)
auto_sbitmap visited (last_basic_block_for_fn (fun));
bitmap_clear (visited);
/* We need accurate notes. Earlier passes such as if-conversion may
leave notes in an inconsistent state. */
df_note_add_problem ();
df_analyze ();
/* It is tempting to set DF_LR_RUN_DCE, but DCE may choose to delete
an insn and this pass would not have visibility into the removal.

6
gcc/testsuite/ChangeLog
View file

@ -1,3 +1,9 @@
2019-03-26 Jeff Law <law@redhat.com>
PR rtl-optimization/87761
PR rtl-optimization/89826
* gcc.c-torture/execute/pr89826.c: New test.
2019-03-27 Richard Biener <rguenther@suse.de>
* gcc.dg/torture/20190327-1.c: New testcase.

21
gcc/testsuite/gcc.c-torture/execute/pr89826.c Normal file
View file

@ -0,0 +1,21 @@
typedef unsigned int u32;
typedef unsigned long long u64;
u64 a;
u32 b;
u64
foo (u32 d)
{
a -= d ? 0 : ~a;
return a + b;
}
int
main (void)
{
u64 x = foo (2);
if (x != 0)
__builtin_abort();
return 0;
}