[PR/target 100316] Allow constant address for __builtin___clear_cache.
__builtin___clear_cache was able to accept constant address for the argument, but it seems no longer accept recently, and it even not accept constant address which is hold in variable when optimization is enable: ``` void foo3(){ void *yy = (void*)0x1000; __builtin___clear_cache(yy, yy); } ``` So this patch make BEGIN and END accept VOIDmode, like cselib_lookup_mem did per Jim Wilson's suggestion. ``` static cselib_val * cselib_lookup_mem (rtx x, int create) { ... addr_mode = GET_MODE (XEXP (x, 0)); if (addr_mode == VOIDmode) addr_mode = Pmode; ``` Changes v2 -> v3: - Use gcc_assert rather than error, maybe_emit_call_builtin___clear_cache is internal use only, and we already checked the type in other place. Changes v1 -> v2: - Check is CONST_INT intead of cehck mode, no new testcase, since constant value with other type like CONST_DOUBLE will catched by front-end. e.g. Code: ```c void foo(){ __builtin___clear_cache(1.11, 0); } ``` Error message: ``` clearcache-double.c: In function 'foo': clearcache-double.c:2:27: error: incompatible type for argument 1 of '__builtin___clear_cache' 2 | __builtin___clear_cache(1.11, 0); | ^~~~ | | | double clearcache-double.c:2:27: note: expected 'void *' but argument is of type 'double' ``` gcc/ChangeLog: PR target/100316 * builtins.c (maybe_emit_call_builtin___clear_cache): Allow CONST_INT for BEGIN and END, and use gcc_assert rather than error. gcc/testsuite/ChangeLog: PR target/100316 * gcc.c-torture/compile/pr100316.c: New.
This commit is contained in:
parent
6d97315a4e
commit
4e5bc4e450
2 changed files with 22 additions and 6 deletions
|
@ -5163,12 +5163,10 @@ default_emit_call_builtin___clear_cache (rtx begin, rtx end)
|
|||
void
|
||||
maybe_emit_call_builtin___clear_cache (rtx begin, rtx end)
|
||||
{
|
||||
if ((GET_MODE (begin) != ptr_mode && GET_MODE (begin) != Pmode)
|
||||
|| (GET_MODE (end) != ptr_mode && GET_MODE (end) != Pmode))
|
||||
{
|
||||
error ("both arguments to %<__builtin___clear_cache%> must be pointers");
|
||||
return;
|
||||
}
|
||||
gcc_assert ((GET_MODE (begin) == ptr_mode || GET_MODE (begin) == Pmode
|
||||
|| CONST_INT_P (begin))
|
||||
&& (GET_MODE (end) == ptr_mode || GET_MODE (end) == Pmode
|
||||
|| CONST_INT_P (end)));
|
||||
|
||||
if (targetm.have_clear_cache ())
|
||||
{
|
||||
|
|
18
gcc/testsuite/gcc.c-torture/compile/pr100316.c
Normal file
18
gcc/testsuite/gcc.c-torture/compile/pr100316.c
Normal file
|
@ -0,0 +1,18 @@
|
|||
void foo(){
|
||||
__builtin___clear_cache(0, 0);
|
||||
}
|
||||
|
||||
void foo1(){
|
||||
__builtin___clear_cache((void*)0, (void*)0);
|
||||
}
|
||||
|
||||
void foo2(){
|
||||
void *yy = 0;
|
||||
__builtin___clear_cache(yy, yy);
|
||||
}
|
||||
|
||||
void foo3(){
|
||||
void *yy = (void*)0x1000;
|
||||
__builtin___clear_cache(yy, yy);
|
||||
}
|
||||
|
Loading…
Add table
Reference in a new issue