procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

report message for operator %a on unaddressible operand

Browse source 
Hi,

For PR96866, when printing asm code for modifier "%a", an addressable
operand is required.  While the constraint "X" allow any kind of
operand even which is hard to get the address directly. e.g. extern
symbol whose address is in TOC.
An error message would be reported to indicate the invalid asm operand.

Compare with previous version, test case is updated with -mno-pcrel.

Bootstrap&regtest pass on ppc64{,le}.
Is this ok for trunk?

BR,
Jeff(Jiufu Guo)

	PR target/96866

gcc/ChangeLog:

	* config/rs6000/rs6000.cc (print_operand_address): Emit message for
	unsupported operand.

gcc/testsuite/ChangeLog:

	* gcc.target/powerpc/pr96866-1.c: New test.
	* gcc.target/powerpc/pr96866-2.c: New test.
This commit is contained in:
Jiufu Guo 2024-07-23 13:34:20 +08:00 • committed by guojiufu
parent 7793f5b419
commit 472eab9ab1
3 changed files with 37 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
gcc/config/rs6000/rs6000.cc
View file

@ -14706,7 +14706,12 @@ print_operand_address (FILE *file, rtx x)
fprintf (file, "@%s(%s)", SMALL_DATA_RELOC,
reg_names[SMALL_DATA_REG]);
else
gcc_assert (!TARGET_TOC);
{
/* Do not support getting address directly from TOC, emit error.
No more work is needed for !TARGET_TOC. */
if (TARGET_TOC)
output_operand_lossage ("%%a requires an address of memory");
}
}
else if (GET_CODE (x) == PLUS && REG_P (XEXP (x, 0))
&& REG_P (XEXP (x, 1)))

18
gcc/testsuite/gcc.target/powerpc/pr96866-1.c Normal file
View file

@ -0,0 +1,18 @@
/* The "%a" modifier can't get the address of extern symbol directly from TOC
with -fPIC, even the symbol is propagated for "X" constraint under -O2. */
/* { dg-options "-fPIC -O2 -mno-pcrel" } */
/* It's to verify no ICE here, ignore error messages about invalid 'asm'. */
/* { dg-excess-errors "pr96866-1.c" } */
int x[2];
int __attribute__ ((noipa))
f1 (void)
{
int n;
int *p = x;
*p++;
__asm__ volatile("ld %0, %a1" : "=r"(n) : "X"(p));
return n;
}

13
gcc/testsuite/gcc.target/powerpc/pr96866-2.c Normal file
View file

@ -0,0 +1,13 @@
/* The "%a" modifier can't get the address of extern symbol directly from TOC
with -fPIC. */
/* { dg-options "-fPIC -O2 -mno-pcrel" } */
/* It's to verify no ICE here, ignore error messages about invalid 'asm'. */
/* { dg-excess-errors "pr96866-2.c" } */
void
f (void)
{
extern int x;
__asm__ volatile("#%a0" ::"X"(&x));
}