procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

The fma_forest, fma_root_node and func_fma_steering classes lack a copy constructor.

Browse source 
The fma_forest, fma_root_node and func_fma_steering classes lack a
copy constructor.  However, they contain pointers to allocated memory
so this omission can be regarded as poor style.  We don't need to copy
such objects, so declare the copy constructor private to inhibit
accidental copying.

2019-04-08  Andrea Corallo  <andrea.corallo@arm.com>

	PR target/83033
	* config/aarch64/cortex-a57-fma-steering.c (fma_forest): Prohibit copy
	construction.
	(fma_root_node): Likewise.
	(func_fma_steering): Likewise.

From-SVN: r270207
This commit is contained in:
Andrea Corallo 2019-04-08 12:59:24 +00:00 • committed by Richard Earnshaw
parent 0d0f212a51
commit 450dd8b3ab
2 changed files with 18 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
gcc/ChangeLog
View file

@ -1,3 +1,11 @@
2019-04-08 Andrea Corallo <andrea.corallo@arm.com>
PR target/83033
* config/aarch64/cortex-a57-fma-steering.c (fma_forest): Prohibit copy
construction.
(fma_root_node): Likewise.
(func_fma_steering): Likewise.
2019-04-08 Jakub Jelinek <jakub@redhat.com>
PR rtl-optimization/89865

10
gcc/config/aarch64/cortex-a57-fma-steering.c
View file

@ -114,6 +114,9 @@ public:
void dispatch ();
private:
/* Prohibit copy construction. */
fma_forest (const fma_forest &);
/* The list of roots that form this forest. */
std::list<fma_root_node *> *m_roots;
@ -148,6 +151,10 @@ public:
void rename (fma_forest *);
void dump_info (fma_forest *);
private:
/* Prohibit copy construction. */
fma_node (const fma_node &);
protected:
/* Root node that lead to this node. */
fma_root_node *m_root;
@ -203,6 +210,9 @@ public:
void execute_fma_steering ();
private:
/* Prohibit copy construction. */
func_fma_steering (const func_fma_steering &);
void dfs (void (*) (fma_forest *), void (*) (fma_forest *, fma_root_node *),
void (*) (fma_forest *, fma_node *), bool);
void analyze ();