procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

* c-typeck.c (comptypes): Handle zero-length arrays properly.

Browse source 
From-SVN: r45641
This commit is contained in:
Richard Henderson 2001-09-15 17:48:52 -07:00 • committed by Richard Henderson
parent c6c04fcab3
commit 3f85558f24
3 changed files with 65 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
gcc/ChangeLog
View file

@ -1,3 +1,7 @@
2001-09-15 Richard Henderson <rth@redhat.com>
* c-typeck.c (comptypes): Handle zero-length arrays properly.
2001-09-15 Roman Lechtchinsky <rl@cs.tu-berlin.de>
* c-common.c (c_promoting_integer_type_p): Handle ?Imode types.

25
gcc/c-typeck.c
View file

@ -505,6 +505,8 @@ comptypes (type1, type2)
{
tree d1 = TYPE_DOMAIN (t1);
tree d2 = TYPE_DOMAIN (t2);
bool d1_variable, d2_variable;
bool d1_zero, d2_zero;
val = 1;
/* Target types must match incl. qualifiers. */
@ -513,14 +515,25 @@ comptypes (type1, type2)
return 0;
/* Sizes must match unless one is missing or variable. */
if (d1 == 0 || d2 == 0 || d1 == d2
|| TREE_CODE (TYPE_MIN_VALUE (d1)) != INTEGER_CST
|| TREE_CODE (TYPE_MIN_VALUE (d2)) != INTEGER_CST
|| TREE_CODE (TYPE_MAX_VALUE (d1)) != INTEGER_CST
|| TREE_CODE (TYPE_MAX_VALUE (d2)) != INTEGER_CST)
if (d1 == 0 || d2 == 0 || d1 == d2)
break;
if (! tree_int_cst_equal (TYPE_MIN_VALUE (d1), TYPE_MIN_VALUE (d2))
d1_zero = ! TYPE_MAX_VALUE (d1);
d2_zero = ! TYPE_MAX_VALUE (d2);
d1_variable = (! d1_zero
&& (TREE_CODE (TYPE_MIN_VALUE (d1)) != INTEGER_CST
|| TREE_CODE (TYPE_MAX_VALUE (d1)) != INTEGER_CST));
d2_variable = (! d2_zero
&& (TREE_CODE (TYPE_MIN_VALUE (d2)) != INTEGER_CST
|| TREE_CODE (TYPE_MAX_VALUE (d2)) != INTEGER_CST));
if (d1_variable || d2_variable)
break;
if (d1_zero && d2_zero)
break;
if (d1_zero || d2_zero
|| ! tree_int_cst_equal (TYPE_MIN_VALUE (d1), TYPE_MIN_VALUE (d2))
|| ! tree_int_cst_equal (TYPE_MAX_VALUE (d1), TYPE_MAX_VALUE (d2)))
val = 0;

42
gcc/testsuite/gcc.dg/array-5.c Normal file
View file

@ -0,0 +1,42 @@
/* { dg-do compile } */
/* { dg-options "" } */
/* Check compatibility of array declarations. */
/* Incomplete decl matches. */
extern char arr0[];
char arr0[1];
/* Two integral expressions must be the same. Note that 0 is
a gcc extension, but it should work like any other constant. */
extern char arr1[1];
char arr1[1];
extern char arr2[0];
char arr2[0];
extern char arr3[0]; /* { dg-error "previous declaration" } */
char arr3[1]; /* { dg-error "conflicting types" } */
/* Variable size matches. */
void func(int n, int m)
{
/* The next two are from the example in c99 6.7.5.2/9. */
{
/* Invalid: not compatible because 4 != 6. */
int a[n][6][m];
int (*p)[4][n+1];
p = a; /* { dg-error "incompatible" } */
}
{
/* Compatible, but defined behavior only if n == 6 and m == n+1. */
int c[n][n][6][m];
int (*r)[n][n][n+1];
r = c;
}
{
/* Compatible, but undefined behavior; (2, 2) is not a constant
expression, and thus A is a VLA. */
int a[(2, 2)];
int (*p)[3];
p = a; /* { dg-bogus "incompatible" "bad vla handling" { xfail *-*-* } } */
}
}