procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

re PR middle-end/51696 ([trans-mem] unsafe indirect function call in struct not properly displayed)

Browse source 
PR middle-end/51696
        * trans-mem.c (diagnose_tm_1): Display indirect calls with no name
        correctly.

From-SVN: r182876
This commit is contained in:
Aldy Hernandez 2012-01-04 14:32:54 +00:00 • committed by Aldy Hernandez
parent 17d038cd90
commit 3a54c45644
3 changed files with 40 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gcc/ChangeLog
View file

@ -1,3 +1,9 @@
2012-01-04 Aldy Hernandez <aldyh@redhat.com>
PR middle-end/51696
* trans-mem.c (diagnose_tm_1): Display indirect calls with no name
correctly.
2012-01-04 Richard Guenther <rguenther@suse.de>
PR middle-end/51750

14
gcc/testsuite/gcc.dg/tm/pr51696.c Normal file
View file

@ -0,0 +1,14 @@
/* { dg-do compile } */
/* { dg-options "-fgnu-tm" } */
struct list {
void (*compare)();
} *listPtr;
static void (*compare)();
__attribute__((transaction_safe))
static void func () {
listPtr->compare(); /* { dg-error "unsafe indirect function call" } */
compare(); /* { dg-error "unsafe function call" } */
}

26
gcc/trans-mem.c
View file

@ -664,9 +664,16 @@ diagnose_tm_1 (gimple_stmt_iterator *gsi, bool *handled_ops_p,
"unsafe function call %qD within "
"atomic transaction", fn);
else
error_at (gimple_location (stmt),
"unsafe function call %qE within "
"atomic transaction", fn);
{
if (!DECL_P (fn) || DECL_NAME (fn))
error_at (gimple_location (stmt),
"unsafe function call %qE within "
"atomic transaction", fn);
else
error_at (gimple_location (stmt),
"unsafe indirect function call within "
"atomic transaction");
}
}
else
{
@ -675,9 +682,16 @@ diagnose_tm_1 (gimple_stmt_iterator *gsi, bool *handled_ops_p,
"unsafe function call %qD within "
"%<transaction_safe%> function", fn);
else
error_at (gimple_location (stmt),
"unsafe function call %qE within "
"%<transaction_safe%> function", fn);
{
if (!DECL_P (fn) || DECL_NAME (fn))
error_at (gimple_location (stmt),
"unsafe function call %qE within "
"%<transaction_safe%> function", fn);
else
error_at (gimple_location (stmt),
"unsafe indirect function call within "
"%<transaction_safe%> function");
}
}
}
}