procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

libcody: fix nonportable shell code in revision.stamp build rule

Browse source 
Two non-portable shell constructs have been long present in libcody's
build rule for revision.stamp: $() instead of ``, and += to append to
a shell variable.  The former seems to work even when bash is
operating as /bin/sh, but += doesn't, and it ends up trying to run
revision+=M as a command name, and issuing an error as that command is
(hopefully) not found.

This patch replaces both constructs with more portable ones.


for  libcody/ChangeLog

	* Makefile.in (revision.stamp): Replace $() and += with more
	portable shell constructs.
This commit is contained in:
Alexandre Oliva 2022-06-03 03:59:01 -03:00 • committed by Alexandre Oliva
parent b168441c8a
commit 39ab2e4c39
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
libcody/Makefile.in
View file

@ -66,11 +66,11 @@ clean:: Makefile
# FIXME: Delete
revision.stamp: $(srcdir)/.
@revision=$$(git -C $(srcdir) rev-parse HEAD 2>/dev/null) ;\
@revision=`git -C $(srcdir) rev-parse HEAD 2>/dev/null` ;\
if test -n "$$revision" ;\
then revision=git-$$revision ;\
if git -C $(srcdir) status --porcelain 2>/dev/null | grep -vq '^ ' ;\
then revision+=M ;\
then revision=$${revision}M ;\
fi ;\
else revision=unknown ;\
fi ;\