procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

match: Reject non-const internal functions [PR117260]

Browse source 
When internal functions support was added to match (r6-4979-gc9e926ce2bdc8b),
the check for ECF_CONST was the builtin function side. Though before r15-4503-g8d6d6d537fdc,
there was no use of maybe_push_res_to_seq with non-const internal functions so the check
would not make a difference.

This adds the check for internal functions just as there is a check for builtins.

Note I didn't add a testcase because there was no non-const internal function
which could be used on x86_64 in a decent manor.

Bootstrapped and tested on x86_64-linux-gnu.

gcc/ChangeLog:

	PR tree-optimization/117260
	* gimple-match-exports.cc (maybe_push_res_to_seq): Reject non-const
	internal functions.

Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>
This commit is contained in:
Andrew Pinski 2024-10-22 09:05:38 -07:00
parent 5467f5b5ca
commit 36e3e68250
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gcc/gimple-match-exports.cc
View file

@ -522,6 +522,11 @@ maybe_push_res_to_seq (gimple_match_op *res_op, gimple_seq *seq, tree res)
{
/* Generate the given function if we can. */
internal_fn ifn = as_internal_fn (fn);
/* We can't and should not emit calls to non-const functions. */
if (!(internal_fn_flags (ifn) & ECF_CONST))
return NULL_TREE;
new_stmt = build_call_internal (ifn, res_op);
if (!new_stmt)
return NULL_TREE;