procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

attribs: Improve diagnostics

Browse source 
When looking at the attribs code, I've noticed weird diagnostics
like
int a __attribute__((section ("foo", "bar")));
a.c:1:1: error: wrong number of arguments specified for ‘section’ attribute
    1 | int a __attribute__((section ("foo", "bar")));
      | ^~~
a.c:1:1: note: expected between 1 and 1, found 2
As roughly 50% of attributes that accept any arguments have
spec->min_length == spec->max_length, I think it is worth it to have
separate wording for such common case and just write simpler
a.c:1:1: note: expected 1, found 2

2022-09-23  Jakub Jelinek  <jakub@redhat.com>

	* attribs.cc (decl_attributes): Improve diagnostics, instead of
	saying expected between 1 and 1, found 2 just say expected 1, found 2.
This commit is contained in:
Jakub Jelinek 2022-09-23 09:10:16 +02:00
parent a282f086ef
commit 2ec6489d7a
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
gcc/attribs.cc
View file

@ -737,6 +737,9 @@ decl_attributes (tree *node, tree attributes, int flags,
if (spec->max_length < 0)
inform (input_location, "expected %i or more, found %i",
spec->min_length, nargs);
else if (spec->min_length == spec->max_length)
inform (input_location, "expected %i, found %i",
spec->min_length, nargs);
else
inform (input_location, "expected between %i and %i, found %i",
spec->min_length, spec->max_length, nargs);