procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

hppa: Fix handling of secondary reloads involving a SUBREG

Browse source 
This is fairly subtle.

When handling spills for SUBREG arguments in pa_emit_move_sequence,
alter_subreg may be called.  It in turn calls adjust_address_1 and
change_address_1.  change_address_1 calls pa_legitimate_address_p
to validate the new spill address.  change_address_1 generates an
internal compiler error if the address is not valid.  We need to
allow 14-bit displacements for all modes when reload_in_progress
is true and strict is false to prevent the internal compiler error.

SUBREGs are only used with the general registers, so the spill
should result in an integer access.  14-bit displacements are okay
for integer loads and stores but not for floating-point loads and
stores.

Potentially, the change could break the handling of spills for the
floating point-registers but I believe these are handled separately
in pa_emit_move_sequence.

This change fixes the build of symmetrica-3.0.1+ds.

2024-11-08  John David Anglin  <danglin@gcc.gnu.org>

gcc/ChangeLog:

	PR target/117443
	* config/pa/pa.cc (pa_legitimate_address_p): Allow any
	14-bit displacement when reload is in progress and strict
	is false.
This commit is contained in:
John David Anglin 2024-11-08 16:34:41 -05:00
parent 80e5be0c7f
commit 1ea45291af
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
gcc/config/pa/pa.cc
View file

@ -11009,6 +11009,7 @@ pa_legitimate_address_p (machine_mode mode, rtx x, bool strict, code_helper)
/* Long 14-bit displacements always okay for these cases. */
if (INT14_OK_STRICT
|| reload_completed
|| (reload_in_progress && !strict)
|| mode == QImode
|| mode == HImode)
return true;