procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

darwin.c (machopic_symbol_defined_p): In addition to being SYMBOL_REF_LOCAL_P...

Browse source 
* config/darwin.c (machopic_symbol_defined_p): In addition to
	being SYMBOL_REF_LOCAL_P, a symbol must also be
	! SYMBOL_REF_EXTERNAL_P, as only those are _always_ locally
	defined in this output file, or translation unit in the case
	of IMA not being used.
	(machopic_output_indirection): SYMBOL_REF_LOCAL_P symbols
	never need .indirect_symbol when indirecting.

From-SVN: r86915
This commit is contained in:
Mike Stump 2004-09-01 17:18:02 +00:00 • committed by Mike Stump
parent ffbef0240f
commit 156a126c4f
3 changed files with 27 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
gcc/ChangeLog
View file

@ -1,3 +1,13 @@
2004-09-01 Mike Stump <mrs@apple.com>
* config/darwin.c (machopic_symbol_defined_p): In addition to
being SYMBOL_REF_LOCAL_P, a symbol must also be
! SYMBOL_REF_EXTERNAL_P, as only those are _always_ locally
defined in this output file, or translation unit in the case
of IMA not being used.
(machopic_output_indirection): SYMBOL_REF_LOCAL_P symbols
never need .indirect_symbol when indirecting.
2004-09-01 Jakub Jelinek <jakub@redhat.com>
* Makefile.in (bb-reorder.o): Add several dependencies.

8
gcc/config/darwin.c
View file

@ -97,9 +97,8 @@ name_needs_quotes (const char *name)
static int
machopic_symbol_defined_p (rtx sym_ref)
{
return ((SYMBOL_REF_FLAGS (sym_ref) & MACHO_SYMBOL_FLAG_DEFINED)
/* Local symbols must always be defined. */
|| SYMBOL_REF_LOCAL_P (sym_ref));
return (SYMBOL_REF_FLAGS (sym_ref) & MACHO_SYMBOL_FLAG_DEFINED)
|| (SYMBOL_REF_LOCAL_P (sym_ref) && ! SYMBOL_REF_EXTERNAL_P (sym_ref));
}
/* This module assumes that (const (symbol_ref "foo")) is a legal pic
@ -874,7 +873,8 @@ machopic_output_indirection (void **slot, void *data)
machopic_output_stub (asm_out_file, sym, stub);
}
else if (! indirect_data (symbol)
&& machopic_symbol_defined_p (symbol))
&& (machopic_symbol_defined_p (symbol)
|| SYMBOL_REF_LOCAL_P (symbol)))
{
data_section ();
assemble_align (GET_MODE_ALIGNMENT (Pmode));

13
gcc/testsuite/gcc.dg/visibility-b.c Normal file
View file

@ -0,0 +1,13 @@
/* { dg-do assemble { target *-*-darwin* } } */
#define __private_extern__ extern __attribute__((visibility ("hidden")))
__private_extern__ int n;
int
mach_error_type(int sub)
{
if (sub >= n)
return 1;
return 0;
}