procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

c++: print conversion error at candidate location

Browse source 
In testcases like this one, the printing of candidates in a diagnostic has
been longer than necessary because it jumps back and forth between the call
site and the candidate site.  So here, we first say at the call site that no
match was found; then we note the candidate site, and then explain why it's
not suitable back at the call site, which means printing the call site line
with caret again.  With this patch, the conversion diagnostic is at the same
location as the candidate, so we don't need to print any input line.

gcc/cp/ChangeLog:

	* call.cc (print_conversion_rejection): Use iloc_sentinel.

gcc/testsuite/ChangeLog:

	* g++.dg/template/copy1.C: Adjust error lines.
This commit is contained in:
Jason Merrill 2023-03-23 10:43:58 -04:00
parent e0cf929d99
commit 14e881eb03
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
gcc/cp/call.cc
View file

@ -3847,6 +3847,7 @@ print_conversion_rejection (location_t loc, struct conversion_info *info,
if (info->n_arg >= 0)
inform (loc, " conversion of argument %d would be ill-formed:",
info->n_arg + 1);
iloc_sentinel ils = loc;
perform_implicit_conversion (info->to_type, info->from,
tf_warning_or_error);
}

3
gcc/testsuite/g++.dg/template/copy1.C
View file

@ -6,9 +6,10 @@
struct A
{
// { dg-error "reference" "" { target c++14_down } .+1 }
A(A&); // { dg-message "A::A" "" { target c++14_down } }
template <class T> A(T); // { dg-message "A::A" "" { target c++14_down } }
};
A a = 0; // { dg-error "" "" { target c++14_down } }
A a = 0; // { dg-error "no match" "" { target c++14_down } }