procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

re PR c/42544 (Bad codegen with signed short cast to unsigned int, then promoted to unsigned long long)

Browse source 
PR c/42544
	PR c/48197
	* c-common.c (shorten_compare): If primopN is first sign-extended
	to opN and then zero-extended to result type, set primopN to opN.

	* gcc.c-torture/execute/pr42544.c: New test.
	* gcc.c-torture/execute/pr48197.c: New test.

From-SVN: r171252
This commit is contained in:
Jakub Jelinek 2011-03-21 18:57:34 +01:00 • committed by Jakub Jelinek
parent 9dfd55f55b
commit 126e660935
5 changed files with 67 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
gcc/ChangeLog
View file

@ -1,3 +1,10 @@
2011-03-20 Jakub Jelinek <jakub@redhat.com>
PR c/42544
PR c/48197
* c-common.c (shorten_compare): If primopN is first sign-extended
to opN and then zero-extended to result type, set primopN to opN.
2011-03-21 Daniel Jacobowitz <dan@codesourcery.com>
* config/arm/unwind-arm.c (__gnu_unwind_pr_common): Correct test

14
gcc/c-family/c-common.c
View file

@ -3301,6 +3301,20 @@ shorten_compare (tree *op0_ptr, tree *op1_ptr, tree *restype_ptr,
primop0 = get_narrower (op0, &unsignedp0);
primop1 = get_narrower (op1, &unsignedp1);
/* If primopN is first sign-extended from primopN's precision to opN's
precision, then zero-extended from opN's precision to
*restype_ptr precision, shortenings might be invalid. */
if (TYPE_PRECISION (TREE_TYPE (primop0)) < TYPE_PRECISION (TREE_TYPE (op0))
&& TYPE_PRECISION (TREE_TYPE (op0)) < TYPE_PRECISION (*restype_ptr)
&& !unsignedp0
&& TYPE_UNSIGNED (TREE_TYPE (op0)))
primop0 = op0;
if (TYPE_PRECISION (TREE_TYPE (primop1)) < TYPE_PRECISION (TREE_TYPE (op1))
&& TYPE_PRECISION (TREE_TYPE (op1)) < TYPE_PRECISION (*restype_ptr)
&& !unsignedp1
&& TYPE_UNSIGNED (TREE_TYPE (op1)))
primop1 = op1;
/* Handle the case that OP0 does not *contain* a conversion
but it *requires* conversion to FINAL_TYPE. */

7
gcc/testsuite/ChangeLog
View file

@ -1,3 +1,10 @@
2011-03-20 Jakub Jelinek <jakub@redhat.com>
PR c/42544
PR c/48197
* gcc.c-torture/execute/pr42544.c: New test.
* gcc.c-torture/execute/pr48197.c: New test.
2011-03-21 Michael Meissner <meissner@linux.vnet.ibm.com>
PR preprocessor/48192

14
gcc/testsuite/gcc.c-torture/execute/pr42544.c Normal file
View file

@ -0,0 +1,14 @@
/* PR c/42544 */
extern void abort (void);
int
main ()
{
signed short s = -1;
if (sizeof (long long) == sizeof (unsigned int))
return 0;
if ((unsigned int) s >= 0x100000000ULL)
abort ();
return 0;
}

25
gcc/testsuite/gcc.c-torture/execute/pr48197.c Normal file
View file

@ -0,0 +1,25 @@
/* PR c/48197 */
extern void abort (void);
static int y = 0x8000;
int
main ()
{
unsigned int x = (short)y;
if (sizeof (0LL) == sizeof (0U))
return 0;
if (0LL > (0U ^ (short)-0x8000))
abort ();
if (0LL > (0U ^ x))
abort ();
if (0LL > (0U ^ (short)y))
abort ();
if ((0U ^ (short)-0x8000) < 0LL)
abort ();
if ((0U ^ x) < 0LL)
abort ();
if ((0U ^ (short)y) < 0LL)
abort ();
return 0;
}