procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

c: ICE with nullptr as case expression [PR108424]

Browse source 
In this ICE-on-invalid, we crash on

  gcc_assert (INTEGRAL_TYPE_P (type));

in perform_integral_promotions, because a nullptr is an INTEGER_CST,
but not INTEGRAL_TYPE_P, and check_case_value is only checking the
former.  In the test I'm testing other "shall be an integral constant
expression" contexts as well.

	PR c/108424

gcc/c-family/ChangeLog:

	* c-common.cc (check_case_value): Check INTEGRAL_TYPE_P.

gcc/testsuite/ChangeLog:

	* gcc.dg/c2x-nullptr-6.c: New test.
This commit is contained in:
Marek Polacek 2023-01-18 14:51:59 -05:00
parent 33237e93d5
commit 0f85ae6591
2 changed files with 35 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
gcc/c-family/c-common.cc
View file

@ -2238,7 +2238,8 @@ check_case_value (location_t loc, tree value)
if (value == NULL_TREE)
return value;
if (TREE_CODE (value) == INTEGER_CST)
if (INTEGRAL_TYPE_P (TREE_TYPE (value))
&& TREE_CODE (value) == INTEGER_CST)
/* Promote char or short to int. */
value = perform_integral_promotions (value);
else if (value != error_mark_node)

33
gcc/testsuite/gcc.dg/c2x-nullptr-6.c Normal file
View file

@ -0,0 +1,33 @@
/* PR c/108424 */
/* { dg-options "-std=c2x" } */
struct S {
int i;
int : nullptr; /* { dg-error "not an integer constant" } */
};
enum E { X = nullptr }; /* { dg-error "not an integer constant" } */
alignas(nullptr) int g; /* { dg-error "not an integer constant" } */
int arr[10] = { [nullptr] = 1 }; /* { dg-error "not of integer type" } */
_Static_assert (nullptr, "nullptr"); /* { dg-error "not an integer" } */
void f (int n)
{
switch (n) {
case nullptr: /* { dg-error "an integer constant" } */
default:
}
switch (n) {
case 1 ... nullptr: /* { dg-error "an integer constant" } */
default:
}
switch (n) {
case nullptr ... 2: /* { dg-error "an integer constant" } */
default:
}
}