procyberian/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

re PR tree-optimization/81603 (Various compiler UB on very large constant offsets)

Browse source 
PR tree-optimization/81603
	* ipa-polymorphic-call.c
	(ipa_polymorphic_call_context::ipa_polymorphic_call_context): Perform
	offset arithmetic in offset_int, bail out if the resulting bit offset
	doesn't fit into shwi.

From-SVN: r250727
This commit is contained in:
Jakub Jelinek 2017-07-31 10:22:14 +02:00 • committed by Jakub Jelinek
parent 3dd9302511
commit 0d1e5925e4
2 changed files with 22 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
gcc/ChangeLog
View file

@ -1,3 +1,11 @@
2017-07-31 Jakub Jelinek <jakub@redhat.com>
PR tree-optimization/81603
* ipa-polymorphic-call.c
(ipa_polymorphic_call_context::ipa_polymorphic_call_context): Perform
offset arithmetic in offset_int, bail out if the resulting bit offset
doesn't fit into shwi.
2017-07-31 Martin Liska <mliska@suse.cz>
* gimplify.c (mostly_copy_tree_r): Remove Java specific hunk.

19
gcc/ipa-polymorphic-call.c
View file

@ -921,9 +921,13 @@ ipa_polymorphic_call_context::ipa_polymorphic_call_context (tree fndecl,
and MEM_REF is meaningless, but we can look futher. */
if (TREE_CODE (base) == MEM_REF)
{
offset_int o = mem_ref_offset (base) * BITS_PER_UNIT;
o += offset;
o += offset2;
if (!wi::fits_shwi_p (o))
break;
base_pointer = TREE_OPERAND (base, 0);
offset
+= offset2 + mem_ref_offset (base).to_short_addr () * BITS_PER_UNIT;
offset = o.to_shwi ();
outer_type = NULL;
}
/* We found base object. In this case the outer_type
@ -961,10 +965,15 @@ ipa_polymorphic_call_context::ipa_polymorphic_call_context (tree fndecl,
break;
}
else if (TREE_CODE (base_pointer) == POINTER_PLUS_EXPR
&& tree_fits_uhwi_p (TREE_OPERAND (base_pointer, 1)))
&& TREE_CODE (TREE_OPERAND (base_pointer, 1)) == INTEGER_CST)
{
offset += tree_to_shwi (TREE_OPERAND (base_pointer, 1))
* BITS_PER_UNIT;
offset_int o = offset_int::from (TREE_OPERAND (base_pointer, 1),
SIGNED);
o *= BITS_PER_UNIT;
o += offset;
if (!wi::fits_shwi_p (o))
break;
offset = o.to_shwi ();
base_pointer = TREE_OPERAND (base_pointer, 0);
}
else