From 05613877bda9a29d72c092b33a92d062f1f9ece4 Mon Sep 17 00:00:00 2001 From: Richard Guenther Date: Tue, 16 Nov 2010 11:42:50 +0000 Subject: [PATCH] re PR middle-end/45172 (internal compiler error: verify_flow_info failed) 2010-11-16 Richard Guenther PR middle-end/45172 * tree-eh.c (cleanup_empty_eh_unsplit): Avoid creating duplicate edges. * gfortran.dg/gomp/pr45172.f90: New testcase. From-SVN: r166794 --- gcc/ChangeLog | 6 ++++++ gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/gfortran.dg/gomp/pr45172.f90 | 21 +++++++++++++++++++++ gcc/tree-eh.c | 18 ++++++++++++++++++ 4 files changed, 50 insertions(+) create mode 100644 gcc/testsuite/gfortran.dg/gomp/pr45172.f90 diff --git a/gcc/ChangeLog b/gcc/ChangeLog index f55283ec6bd..7f68583fa07 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2010-11-16 Richard Guenther + + PR middle-end/45172 + * tree-eh.c (cleanup_empty_eh_unsplit): Avoid creating duplicate + edges. + 2010-11-16 Nick Clifton * config/rx/rx.c (rx_is_ms_bitfield_layout): Return false if the diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index ee1bcceb8e4..b2ee19ced9a 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2010-11-16 Richard Guenther + + PR middle-end/45172 + * gfortran.dg/gomp/pr45172.f90: New testcase. + 2010-11-16 Nick Clifton * gcc.target/rx/pack.c: New test. diff --git a/gcc/testsuite/gfortran.dg/gomp/pr45172.f90 b/gcc/testsuite/gfortran.dg/gomp/pr45172.f90 new file mode 100644 index 00000000000..dbb242bb15e --- /dev/null +++ b/gcc/testsuite/gfortran.dg/gomp/pr45172.f90 @@ -0,0 +1,21 @@ +! { dg-do compile } +! { dg-options "-O -fopenmp -fexceptions" } + + SUBROUTINE dbcsr_mult_m_e_e ( ) + LOGICAL, PARAMETER :: use_combined_types = .FALSE. + INTEGER, ALLOCATABLE, DIMENSION(:, :) :: right_index_sr + INTEGER, ALLOCATABLE, DIMENSION(:, :, :) :: my_sizes + INTEGER, ALLOCATABLE, DIMENSION(:, :, :, :) :: all_sizes + ALLOCATE (all_sizes(4, LBOUND(my_sizes,2):UBOUND(my_sizes,2), & + LBOUND(my_sizes,3):UBOUND(my_sizes,3), 0:numnodes-1)) + IF (use_combined_types) THEN + CALL mp_waitall (right_index_sr) + ENDIF + DO ki = 0, min_nimages-1 +!$omp parallel default (none) & +!$omp reduction (+: flop_single, t_all, t_dgemm) +!$omp end parallel + ENDDO + checksum = dbcsr_checksum (product_matrix, error) + END SUBROUTINE dbcsr_mult_m_e_e + diff --git a/gcc/tree-eh.c b/gcc/tree-eh.c index 8a99ad3aa4f..270d76d9480 100644 --- a/gcc/tree-eh.c +++ b/gcc/tree-eh.c @@ -3670,6 +3670,8 @@ cleanup_empty_eh_unsplit (basic_block bb, edge e_out, eh_landing_pad lp) { gimple_stmt_iterator gsi; tree lab; + edge_iterator ei; + edge e; /* We really ought not have totally lost everything following a landing pad label. Given that BB is empty, there had better @@ -3692,6 +3694,22 @@ cleanup_empty_eh_unsplit (basic_block bb, edge e_out, eh_landing_pad lp) return false; } + /* The destination block must not be a regular successor for any + of the preds of the landing pad. Thus, avoid turning + <..> + | \ EH + | <..> + | / + <..> + into + <..> + | | EH + <..> + which CFG verification would choke on. See PR45172. */ + FOR_EACH_EDGE (e, ei, bb->preds) + if (find_edge (e->src, e_out->dest)) + return false; + /* Attempt to move the PHIs into the successor block. */ if (cleanup_empty_eh_merge_phis (e_out->dest, bb, e_out, false)) {