From 03a5f060b9bdcf4520645cb4e6c15297e3eea060 Mon Sep 17 00:00:00 2001 From: Jakub Jelinek Date: Tue, 30 Mar 2010 22:16:52 +0200 Subject: [PATCH] re PR debug/43593 (Var-tracking unnecessarily flushes all call used registers on calls instead of regs invalidated by call) PR debug/43593 * var-tracking.c (dataflow_set_clear_at_call): Invalidate just regs_invalidated_by_call instead all call_used_reg_set registers. * gcc.dg/guality/pr43593.c: New test. From-SVN: r157834 --- gcc/ChangeLog | 7 +++++++ gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/gcc.dg/guality/pr43593.c | 24 ++++++++++++++++++++++++ gcc/var-tracking.c | 2 +- 4 files changed, 37 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.dg/guality/pr43593.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index a533a7fef60..cddbce7fad3 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,10 @@ +2010-03-30 Jakub Jelinek + + PR debug/43593 + * var-tracking.c (dataflow_set_clear_at_call): Invalidate + just regs_invalidated_by_call instead all call_used_reg_set + registers. + 2010-03-30 Sebastian Pop PR middle-end/43430 diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index c9ede61b356..a7af1c643f2 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2010-03-30 Jakub Jelinek + + PR debug/43593 + * gcc.dg/guality/pr43593.c: New test. + 2010-03-30 Sebastian Pop PR middle-end/43430 diff --git a/gcc/testsuite/gcc.dg/guality/pr43593.c b/gcc/testsuite/gcc.dg/guality/pr43593.c new file mode 100644 index 00000000000..d8cc41359be --- /dev/null +++ b/gcc/testsuite/gcc.dg/guality/pr43593.c @@ -0,0 +1,24 @@ +/* PR debug/43593 */ +/* { dg-do run } */ +/* { dg-options "-g" } */ + +void __attribute__((noinline)) +bar (int *p) +{ + asm volatile ("" : : "r" (p) : "memory"); +} + +int __attribute__((noinline)) +foo (void) +{ + int i, *j = &i; + bar (j); + return 6 + i; /* { dg-final { gdb-test 16 "j" "&i" } } */ +} + +int +main (void) +{ + foo (); + return 0; +} diff --git a/gcc/var-tracking.c b/gcc/var-tracking.c index bff7d119d73..e0f722974d0 100644 --- a/gcc/var-tracking.c +++ b/gcc/var-tracking.c @@ -4170,7 +4170,7 @@ dataflow_set_clear_at_call (dataflow_set *set) int r; for (r = 0; r < FIRST_PSEUDO_REGISTER; r++) - if (TEST_HARD_REG_BIT (call_used_reg_set, r)) + if (TEST_HARD_REG_BIT (regs_invalidated_by_call, r)) var_regno_delete (set, r); if (MAY_HAVE_DEBUG_INSNS)