c++: ICE in build_deduction_guide for invalid template [PR105760]

We currently ICE upon the following invalid snippet because we fail to
properly handle tsubst_arg_types returning error_mark_node in
build_deduction_guide.

== cut ==
template<class... Ts, class>
struct A { A(Ts...); };
A a;
== cut ==

This patch fixes this, and has been successfully tested on x86_64-pc-linux-gnu.

	PR c++/105760

gcc/cp/ChangeLog:

	* pt.cc (build_deduction_guide): Check for error_mark_node
	result from tsubst_arg_types.

gcc/testsuite/ChangeLog:

	* g++.dg/parse/error66.C: New test.
This commit is contained in:
Simon Martin 2024-05-06 15:20:10 +02:00 committed by Jason Merrill
parent 1288283051
commit 0003e469d4
2 changed files with 8 additions and 0 deletions

View file

@ -30031,6 +30031,8 @@ build_deduction_guide (tree type, tree ctor, tree outer_args, tsubst_flags_t com
references to members of an unknown specialization. */
cp_evaluated ev;
fparms = tsubst_arg_types (fparms, targs, NULL_TREE, complain, ctor);
if (fparms == error_mark_node)
ok = false;
fargs = tsubst (fargs, targs, complain, ctor);
if (ci)
{

View file

@ -0,0 +1,6 @@
// PR c++/105760
// { dg-do compile { target c++17 } }
template<class... Ts, class> // { dg-error "must be at the end of the template parameter list" }
struct A { A(Ts...); };
A a;