firmware-open/scripts/_build/ec.sh

#!/usr/bin/env bash

# shellcheck disable=SC1090

set -e

if [ -z "$1" ] || [ ! -e "$1" ] || [ -z "$2" ]
then
    echo "$0 <config> <output>" >&2
    exit 1
fi

EC_ARGS=()
while read line; do
    if [[ "$line" != "#"* ]]; then
        EC_ARGS+=("$line")
    fi
done < "$1"

BUILD_DIR="build"

make -C ec BUILD="$BUILD_DIR" clean
make -C ec VERSION="${VERSION}" "${EC_ARGS[@]}" BUILD="$BUILD_DIR" -j "$(nproc)"
cp "ec/$BUILD_DIR/ec.rom" "$2"
Build EC as a submodule, specifying version For models that use System76 EC, we want to have the board version and the EC version matich. Ref: https://github.com/system76/firmware-open/issues/75 2020-04-06 14:49:40 -06:00			`#!/usr/bin/env bash`

scripts: Address shellcheck issues Report issues by shell files with: git ls-files '.sh' \| xargs shellcheck --exclude=SC2162 Address the following: - SC1087: Use braces when expanding arrays - SC1091: Not following - SC2004: `$`/`${}` is unnecessary on arithmetic variables - SC2024: `sudo` doesn't affect redirects - SC2034: foo appears unused. Verify it or export it - SC2086: Double quote to prevent globbing and word splitting - SC2087: Quote `EOF` - SC2115: Use `"${var:?}"` to ensure this never expands to `/` - SC2148: Add a shebang Addresses (at least partially) some POSIX/dash issues: - SC2113: `function` keyword is non-standard - SC3010: In POSIX sh, `[[` `]]` is undefined - SC3014: In POSIX sh, `==` in place of `=` is undefined - SC3020: In POSIX sh, `&>` is undefined - SC3046: In POSIX sh, `source` in place of `.` is undefined Does not address: - SC2162: `read` without `-r` will mangle backslashes - Any other POSIX/dash-specific issues Signed-off-by: Tim Crawford <tcrawford@system76.com> 2023-10-13 21:53:41 -06:00			`# shellcheck disable=SC1090`

Build EC as a submodule, specifying version For models that use System76 EC, we want to have the board version and the EC version matich. Ref: https://github.com/system76/firmware-open/issues/75 2020-04-06 14:49:40 -06:00			`set -e`

scripts: Address shellcheck issues Report issues by shell files with: git ls-files '.sh' \| xargs shellcheck --exclude=SC2162 Address the following: - SC1087: Use braces when expanding arrays - SC1091: Not following - SC2004: `$`/`${}` is unnecessary on arithmetic variables - SC2024: `sudo` doesn't affect redirects - SC2034: foo appears unused. Verify it or export it - SC2086: Double quote to prevent globbing and word splitting - SC2087: Quote `EOF` - SC2115: Use `"${var:?}"` to ensure this never expands to `/` - SC2148: Add a shebang Addresses (at least partially) some POSIX/dash issues: - SC2113: `function` keyword is non-standard - SC3010: In POSIX sh, `[[` `]]` is undefined - SC3014: In POSIX sh, `==` in place of `=` is undefined - SC3020: In POSIX sh, `&>` is undefined - SC3046: In POSIX sh, `source` in place of `.` is undefined Does not address: - SC2162: `read` without `-r` will mangle backslashes - Any other POSIX/dash-specific issues Signed-off-by: Tim Crawford <tcrawford@system76.com> 2023-10-13 21:53:41 -06:00			`if [ -z "$1" ] \|\| [ ! -e "$1" ] \|\| [ -z "$2" ]`
Build EC as a submodule, specifying version For models that use System76 EC, we want to have the board version and the EC version matich. Ref: https://github.com/system76/firmware-open/issues/75 2020-04-06 14:49:40 -06:00			`then`
			`echo "$0 <config> <output>" >&2`
			`exit 1`
			`fi`

scripts: Allow additional EC configs Modify the build script to allow setting additional EC configs, similar to how edk2 is done. Signed-off-by: Tim Crawford <tcrawford@system76.com> 2023-05-23 07:11:28 -06:00			`EC_ARGS=()`
			`while read line; do`
			`if [[ "$line" != "#"* ]]; then`
			`EC_ARGS+=("$line")`
			`fi`
			`done < "$1"`

scripts: Always set EC build dir Building EC was broken as the build output from the previous board was not being cleaned. `BUILD` is now always set, defaulting to "build", instead of only when `BOARD` is specified. For good measure, add it to the clean command in case a custom path is used. Fixes: 569321f9ac79 ("scripts: Set EC build dir") Signed-off-by: Tim Crawford <tcrawford@system76.com> 2023-10-12 12:52:30 -06:00			`BUILD_DIR="build"`

			`make -C ec BUILD="$BUILD_DIR" clean`
			`make -C ec VERSION="${VERSION}" "${EC_ARGS[@]}" BUILD="$BUILD_DIR" -j "$(nproc)"`
			`cp "ec/$BUILD_DIR/ec.rom" "$2"`