procyberian/emacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
emacs/lisp/emacs-lisp
History
Stefan Monnier 2a78f06ef4 cl-symbol-macrolet: Fix recent regression 
The recent fix for bug#57397 introduced a regression, breaking
the `cl-lib-symbol-macrolet-hide` test.  It turned out that the
origin of the problem was that `gv.el` uses `macroexpand-1` which
does not (can't) use `macroexpand` but `cl-symbol-macrolet` failed
to advise `macroexpand-1` the way it advised `macroexpand`.

To fix this, we change `cl-symbol-macrolet` so it advises both, and we
do that with a new `macroexpand` advice which delegates the bulk of
the work to `macroexpand-1`.

Along the way, I bumped into another bug in the interaction between
`cl-letf` and `cl-symbol-macrolet`, which I tried to fix in `cl-letf`.

I hear the war on `cl-symbol-macrolet` was a failure.
Maybe ... just say no?

* lisp/emacs-lisp/cl-macs.el (cl--sm-macroexpand-1): New function,
extracted from `cl--sm-macroexpand`.
(cl--sm-macroexpand): Rewrite completely.
(cl-symbol-macrolet): Advise both `macroexpand` and `macroexpand-1`.
(cl--letf): Don't use the "simple variable" code for symbol macros.

* test/lisp/emacs-lisp/cl-lib-tests.el (cl-lib-symbol-macrolet-hide):
Revert last change because the test was right.

* test/lisp/emacs-lisp/cl-macs-tests.el
(cl-macs-test--symbol-macrolet): Add a test case.
2022-09-06 00:08:35 -04:00
..
advice.el (compiled-function-p): New function (bug#56648) 2022-08-14 12:30:05 -04:00
avl-tree.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
backquote.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
backtrace.el Make point-at-eol and point-at-bol obsolete 2022-08-23 04:54:57 +02:00
benchmark.el * Have `benchmark-run-compiled' use the native compiler when available 2022-01-27 11:55:21 +01:00
bindat.el bindat (strz): Null terminate fixed-length strings if there is room 2022-06-22 16:55:40 +03:00
byte-opt.el Update function properties and optimisations 2022-08-21 16:26:59 +02:00
byte-run.el Make it possible to mark generalized variables as obsolete 2022-08-21 21:46:14 +02:00
bytecomp.el Fix warning about obsoleted generalized variables 2022-08-25 14:54:49 +02:00
cconv.el ; * lisp/emacs-lisp/cconv.el (cconv--var-classification): Optimise. 2022-07-09 11:53:30 +02:00
chart.el Make XEmacs compat alias face-background-pixmap obsolete 2022-08-23 16:51:31 +02:00
check-declare.el Make 'check-declare-directory' more portable 2022-05-14 19:08:55 +03:00
checkdoc.el ; Delete not-useful comments referring to Emacs 19. 2022-08-19 18:05:51 +02:00
cl-extra.el string-equal-ignore-case: new function 2022-07-26 13:49:28 -04:00
cl-generic.el (cl--generic-compiler): Revert last change 2022-06-29 08:58:13 -04:00
cl-indent.el Remove some useless eval-when-compile 2022-07-04 14:56:11 +02:00
cl-lib.el Avoid cl-cXXXr compat aliases 2022-08-03 02:59:40 +02:00
cl-macs.el cl-symbol-macrolet: Fix recent regression 2022-09-06 00:08:35 -04:00
cl-preloaded.el ; Fix typos. 2022-07-02 10:20:23 +02:00
cl-print.el nadvice.el: Use OClosures 2022-04-26 17:36:13 -04:00
cl-seq.el cl-reduce doc string improvement 2022-08-18 15:07:08 +02:00
comp-cstr.el * Rename `comp--typeof-builtin-types' 2022-08-18 23:41:39 +02:00
comp.el Merge from origin/emacs-28 2022-09-05 06:30:32 +02:00
copyright.el Fix copyright-fix-years, use a dash to separate years in a range 2022-01-28 15:23:05 +01:00
crm.el Fix crm.el compilation warning 2022-07-11 13:34:35 +02:00
cursor-sensor.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
debug-early.el Make debug-early-backtrace more resilient 2022-06-24 11:04:51 +02:00
debug.el Prefer defvar-keymap in emacs-lisp/*.el 2022-07-04 22:15:51 +02:00
derived.el ; Normalize some "Author" headers 2022-07-20 22:38:01 +02:00
disass.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
easy-mmode.el Fix define-minor-mode :keymap obsoletion warning 2022-09-02 14:58:30 +02:00
easymenu.el ; Minor doc fix in easy-menu-{add,remove} 2022-08-23 16:24:54 +02:00
edebug.el ; Delete not-useful comments referring to Emacs 19. 2022-08-19 18:05:51 +02:00
eieio-base.el * lisp/emacs-lisp/eieio-base.el (eieio-persistent-read): Simplify. 2022-07-31 12:04:17 +02:00
eieio-core.el Move EIEIO autoloads to the common loaddefs.el 2022-07-11 14:29:33 +02:00
eieio-custom.el Move EIEIO autoloads to the common loaddefs.el 2022-07-11 14:29:33 +02:00
eieio-datadebug.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
eieio-opt.el Move EIEIO autoloads to the common loaddefs.el 2022-07-11 14:29:33 +02:00
eieio-speedbar.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
eieio.el Fix ede byte-compile warnings in loaddefs.el 2022-07-31 11:39:00 +02:00
eldoc.el Don't disable eldoc when doing edebug 2022-08-02 11:56:55 +02:00
elint.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
elp.el ; Delete not-useful comments referring to Emacs 19. 2022-08-19 18:05:51 +02:00
ert-x.el ; * lisp/emacs-lisp/ert-x.el (tramp-remote-path): Fix last change. 2022-07-10 20:07:37 +02:00
ert.el Simplify code using take, ntake and butlast 2022-08-14 15:43:12 +02:00
ewoc.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
faceup.el Audit quoting the quote character in doc strings 2022-04-22 16:17:22 +02:00
find-func.el Add find-function-setup-keys bindings for find-library commands 2022-06-30 12:49:40 +02:00
float-sup.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
generate-lisp-file.el Inhibit nativecomp of loaddefs files 2022-09-03 14:23:26 +02:00
generator.el Merge from origin/emacs-28 2022-01-01 07:03:03 -05:00
generic.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
gv.el gv.el and cl-macs.el: Fix bug#57397 2022-09-03 22:38:28 -04:00
helper.el Don't show status message in Helper-describe-bindings 2022-08-11 14:35:23 +02:00
hierarchy.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
icons.el Fix some no-X build warnings 2022-08-22 19:22:33 +02:00
inline.el Fix Edebug specification for inline functions (Bug#53068). 2022-01-13 13:52:40 +01:00
let-alist.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
lisp-mnt.el lisp-mnt, checkdoc: Reduce run-time dependencies 2022-02-07 12:59:27 -05:00
lisp-mode.el Revert the changes to lisp-current-defun-name 2022-08-23 12:26:24 +02:00
lisp.el ; * lisp/emacs-lisp/lisp.el (end-of-defun-moves-to-eol): Doc fix. 2022-08-06 09:40:07 +03:00
loaddefs-gen.el Inhibit nativecomp of loaddefs files 2022-09-03 14:23:26 +02:00
macroexp.el * lisp/emacs-lisp/macroexp.el (macroexp--compiler-macro): Soften message 2022-09-03 11:03:32 -04:00
map-ynp.el Clarify read-answer-short/use-short-answers action 2022-04-07 13:37:16 +02:00
map.el Mention caveats in the map-delete doc string 2022-04-26 15:34:26 +02:00
memory-report.el Make memory-report not bug out with symbols with positions 2022-05-26 13:04:50 +02:00
multisession.el Speed up multisession--set-value-sqlite slightly 2022-01-22 15:13:27 +01:00
nadvice.el ; advice--interactive-form: Fix a typo introduced in recent change 2022-08-14 10:23:29 +02:00
oclosure.el * lisp/emacs-lisp/oclosure.el (oclosure-define): Fix empty case 2022-05-08 10:33:49 -04:00
package-x.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
package.el Use help-key-binding face in package list help 2022-08-12 15:08:19 +02:00
pcase.el (compiled-function-p): New function (bug#56648) 2022-08-14 12:30:05 -04:00
pp.el pp--insert-lisp: Don't bug out on certain forms at beginning of buffer 2022-05-28 18:39:43 +02:00
radix-tree.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
range.el Move the Gnus range functions to a new range.el file 2022-01-17 15:47:50 +01:00
re-builder.el Fit the re-builder window to the buffer 2022-09-05 20:58:27 +02:00
regexp-opt.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
regi.el ; * lisp/emacs-lisp/regi.el: Delete incorrect "last modified" comment. 2022-07-30 11:36:36 +02:00
ring.el * lisp/emacs-lisp/ring.el (ring): Define as a type 2022-08-14 12:30:06 -04:00
rmc.el Allow read-multiple-choice to do long-form answers 2022-06-24 11:04:51 +02:00
rx.el Reduce internal rx autoloads 2022-07-31 13:01:26 +02:00
seq.el Add new function `seq-positions' 2022-09-04 13:21:59 +02:00
shadow.el string-equal-ignore-case: new function 2022-07-26 13:49:28 -04:00
shortdoc.el Add new function `seq-positions' 2022-09-04 13:21:59 +02:00
shorthands.el Remove some useless eval-when-compile 2022-07-04 14:56:11 +02:00
smie.el * lisp/emacs-lisp/smie.el (smie-auto-fill): Fix bug#19342 2022-05-06 11:09:58 -04:00
subr-x.el Hide local variable section in emacs-news-modes 2022-08-12 22:28:17 +02:00
syntax.el (syntax-wholeline-max): New var 2022-06-30 13:20:33 -04:00
tabulated-list.el Prefer pos-bol and pos-eol in tabulated-list.el 2022-08-22 15:08:48 +02:00
tcover-ses.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
testcover.el ; * lisp/emacs-lisp/testcover.el: Remove duplicate provide. 2022-06-30 14:12:12 +02:00
text-property-search.el Audit quoting the quote character in doc strings 2022-04-22 16:17:22 +02:00
thunk.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
timer-list.el Add quit-window entry to list-timers menu 2022-07-04 22:15:51 +02:00
timer.el time-convert): Deprecate calls without an explicit FORM arg 2022-08-05 18:46:31 -04:00
tq.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
trace.el ; Delete LCD Archive entries 2022-07-28 15:07:34 +02:00
unsafep.el ; Add 2022 to copyright years. 2022-01-01 02:45:51 -05:00
vtable.el Don't make a header if the user hasn't specified columns in vtable 2022-04-23 14:47:55 +02:00
warnings.el Fix variable types in warnings-suppress 2022-08-15 09:36:06 +02:00